CLN: Collapse private ._take implementation into the public take method #27349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endenis
changed the title
WillAyd
reviewed
Jul 11, 2019
| @Appender(generic.NDFrame._take.__doc__) | ||
| def _take(self, indices, axis=0, is_copy=False): | ||
| @Appender(generic.NDFrame.take.__doc__) | ||
| def take(self, indices, axis=0, is_copy=False, **kwargs): |
There was a problem hiding this comment.
Do we need to add kwargs here or did you just add this for consistency?
There was a problem hiding this comment.
I added it for consistency:
Series class inherits from the NDFrame, so I wanted to preserve the same signature for take.
|
thanks @endenis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffGetting rid the
_takeprivate method that seems to be no longer needed.