Skip to content

CLN: Collapse private ._take implementation into the public take method #27174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mroeschke opened this issue Jul 2, 2019 · 0 comments · Fixed by #27349
Closed

CLN: Collapse private ._take implementation into the public take method #27174

mroeschke opened this issue Jul 2, 2019 · 0 comments · Fixed by #27349
Labels
Clean good first issue Refactor Internal refactoring of code
Milestone
0.25.0

Comments

@mroeschke
Copy link
Member

xref #27171 (comment)

An internal ._take method was created to process a keyword argument deprecation.
Now that both ._take and .take have the same signature, the code within ._take can be collapsed into the public .take method.

pandas/pandas/core/generic.py

Line 3322 in 527e714

def _take(self, indices, axis=0, is_copy=True):

@mroeschke mroeschke added Clean good first issue Refactor Internal refactoring of code labels Jul 2, 2019
@mroeschke mroeschke added this to the Contributions Welcome milestone Jul 2, 2019
@mroeschke mroeschke mentioned this issue Jul 2, 2019
Merged
4 tasks
endenis added a commit to endenis/pandas that referenced this issue Jul 11, 2019
@endenis
CLN: Collapse private ._take implementation into the public take method
09a622b 
pandas-dev#27174
@endenis endenis mentioned this issue Jul 11, 2019
Merged
5 tasks
@jreback jreback modified the milestones: Contributions Welcome, 0.25.0 Jul 12, 2019
jreback pushed a commit that referenced this issue Jul 12, 2019
@endenis @jreback
CLN: Collapse private ._take implementation into the public take method
423ca86 
#27174 (#27349)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean good first issue Refactor Internal refactoring of code
Projects
None yet
Milestone
0.25.0
Development

Successfully merging a pull request may close this issue.

CLN: Collapse private ._take implementation into the public take method endenis/pandas
2 participants
@jreback @mroeschke