BUG: Fix empty closed window issue with rolling min and max #27140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihsansecer
changed the title
jreback
requested changes
Jun 30, 2019
pandas/tests/test_window.py
Outdated
| @pytest.mark.parametrize("closed", ["neither", "left"]) | ||
| @pytest.mark.parametrize( | ||
| "func", ["std", "mean", "median", "sum", "max", "min", "var"]) | ||
| def test_closed_empty(self, closed, func): |
There was a problem hiding this comment.
we have a fixture for these - look in pandas/conftest
There was a problem hiding this comment.
I guess it is all_numeric_reductions but prod function fails since it is not implemented for Rolling. I will add kurt and skew to the list
There was a problem hiding this comment.
you may need to define a separate fixture to avoid some issues
jreback
reviewed
Jul 1, 2019
| @@ -48,6 +48,12 @@ def win_types_special(request): | |||
| return request.param | |||
|
|
|||
|
|
|||
| @pytest.fixture(params=["sum", "mean", "median", "max", "min", | |||
There was a problem hiding this comment.
ok this is fine; can you do a followup to use this fixture as much as possible in this file?
jreback
approved these changes
Jul 1, 2019
|
thanks @ihsansecer very nice, keep em coming! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff