Skip to content

BUG: Fix skiplist init error with empty window #26940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ihsansecer
Copy link
Contributor

@ihsansecer ihsansecer commented Jun 19, 2019

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #26940 into master will decrease coverage by 50.74%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #26940       +/-   ##
===========================================
- Coverage   91.87%   41.12%   -50.75%     
===========================================
  Files         180      180               
  Lines       50746    50743        -3     
===========================================
- Hits        46624    20870    -25754     
- Misses       4122    29873    +25751
Flag Coverage Δ
#multiple ?
#single 41.12% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/plotting/_matplotlib/__init__.py 0% <0%> (-100%) ⬇️
pandas/io/gcs.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/io/s3.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.37%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.16%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.1%) ⬇️
... and 132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baeb1bf...aa20ef4. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #26940 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26940      +/-   ##
==========================================
- Coverage   91.87%   91.86%   -0.01%     
==========================================
  Files         180      180              
  Lines       50746    50746              
==========================================
- Hits        46623    46619       -4     
- Misses       4123     4127       +4
Flag Coverage Δ
#multiple 90.46% <ø> (ø) ⬆️
#single 41.1% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfd65e9...8efc7e6. Read the comment docs.

To check if it causes unexpected CI pd namespace assertion err
@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Window rolling, ewma, expanding Bug Datetime Datetime data dtype and removed Testing pandas testing functions or related to the test suite labels Jun 20, 2019
@gfyoung
Copy link
Member

gfyoung commented Jun 20, 2019

@ihsansecer : FYI, when you write "don't close #26005", GitHub doesn't recognize the negative in your statement and thinks you're trying to close the issue.

To confirm: this PR only partially addresses the issue, correct?

@ihsansecer
Copy link
Contributor Author

@gfyoung didn't know that thanks. Yes it is correct.

@jreback jreback added this to the 0.25.0 milestone Jun 21, 2019
@jreback jreback merged commit 58cbf81 into pandas-dev:master Jun 21, 2019
@jreback
Copy link
Contributor

jreback commented Jun 21, 2019

thanks @ihsansecer nice patch, let's see if need to rebase #26910

@ihsansecer ihsansecer deleted the fix-skiplist-init-err-empty-window branch July 11, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Datetime Datetime data dtype Window rolling, ewma, expanding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants