-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Fix skiplist init error with empty window #26940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fix skiplist init error with empty window #26940
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26940 +/- ##
===========================================
- Coverage 91.87% 41.12% -50.75%
===========================================
Files 180 180
Lines 50746 50743 -3
===========================================
- Hits 46624 20870 -25754
- Misses 4122 29873 +25751
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26940 +/- ##
==========================================
- Coverage 91.87% 91.86% -0.01%
==========================================
Files 180 180
Lines 50746 50746
==========================================
- Hits 46623 46619 -4
- Misses 4123 4127 +4
Continue to review full report at Codecov.
|
To check if it causes unexpected CI pd namespace assertion err
@ihsansecer : FYI, when you write "don't close #26005", GitHub doesn't recognize the negative in your statement and thinks you're trying to close the issue. To confirm: this PR only partially addresses the issue, correct? |
@gfyoung didn't know that thanks. Yes it is correct. |
thanks @ihsansecer nice patch, let's see if need to rebase #26910 |
git diff upstream/master -u -- "*.py" | flake8 --diff