ERR: Raise error in to_excel when saving datetimes with timezones #27129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @WillAyd |
mroeschke
added
Error Reporting
WillAyd
requested changes
Jun 29, 2019
| data = pd.Timestamp('2019', tz=tz) | ||
| df = DataFrame([data], dtype=dtype) | ||
| with pytest.raises(ValueError, match="Excel does not support"): | ||
| df.to_excel(self.path, engine=engine) |
There was a problem hiding this comment.
Just call this without the engine argument - it's already set during test setup so this would be duplicative
That entire mechanism needs a refactor but separate exercise for #27096
WillAyd
approved these changes
Jun 29, 2019
pandas/io/formats/excel.py
Outdated
| @@ -402,6 +402,10 @@ def _format_value(self, val): | |||
| val = '-{inf}'.format(inf=self.inf_rep) | |||
| elif self.float_format is not None: | |||
| val = float(self.float_format % val) | |||
| if getattr(val, 'tzinfo', None) is not None: | |||
| raise ValueError('Excel does not support datetimes with timzones. ' | |||
There was a problem hiding this comment.
small typo here for timezones if you want to fix locally (otherwise can do before merge)
|
Hello @mroeschke! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-06-29 17:08:50 UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffRaise a consistent error, regardless of the writing engine, when saving datetimes with timezones in Excel since they are unsupported.