You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now for readers we test directly setting engine= as a keyword argument, whereas in the writer tests we set the global option. I think we should consistently set the keyword argument and simply have a test on both reading / writing that setting the option will actually trigger that keyword argument to improve coverage and keep things simple
The text was updated successfully, but these errors were encountered:
Follow up to this #25092 (comment)
Right now for readers we test directly setting
engine=
as a keyword argument, whereas in the writer tests we set the global option. I think we should consistently set the keyword argument and simply have a test on both reading / writing that setting the option will actually trigger that keyword argument to improve coverage and keep things simpleThe text was updated successfully, but these errors were encountered: