Skip to content

Clean Up Testing of Excel Engine Option Setting for Readers/Writers #27096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WillAyd opened this issue Jun 28, 2019 · 2 comments
Closed

Clean Up Testing of Excel Engine Option Setting for Readers/Writers #27096

WillAyd opened this issue Jun 28, 2019 · 2 comments
Labels
IO Excel read_excel, to_excel Testing pandas testing functions or related to the test suite

Comments

@WillAyd
Copy link
Member

WillAyd commented Jun 28, 2019

Follow up to this #25092 (comment)

Right now for readers we test directly setting engine= as a keyword argument, whereas in the writer tests we set the global option. I think we should consistently set the keyword argument and simply have a test on both reading / writing that setting the option will actually trigger that keyword argument to improve coverage and keep things simple

@WillAyd WillAyd added Testing pandas testing functions or related to the test suite IO Excel read_excel, to_excel labels Jun 28, 2019
@WillAyd WillAyd added this to the Contributions Welcome milestone Jun 28, 2019
@jbrockmendel
Copy link
Member

Has this been addressed? IIRC we did quite some refactoring of excel tests in late 2019

@WillAyd
Copy link
Member Author

WillAyd commented Sep 29, 2020

It's open ended - let's close for now can come back if there's something concretely actionable

@WillAyd WillAyd closed this as completed Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Excel read_excel, to_excel Testing pandas testing functions or related to the test suite
Projects
None yet
Development

No branches or pull requests

2 participants