-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Fix indexing on DatetimeBlock #27110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
64f2197
ee96e17
6e9522c
2ec8eed
706b84d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -421,11 +421,12 @@ def test_agg_timezone_round_trip(): | |
assert ts == grouped.nth(0)['B'].iloc[0] | ||
assert ts == grouped.head(1)['B'].iloc[0] | ||
assert ts == grouped.first()['B'].iloc[0] | ||
assert ts == grouped.apply(lambda x: x.iloc[0])[0] | ||
assert ts == grouped.apply(lambda x: x.iloc[0]).iloc[0, 0] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you reference this issue and maybe put a comment here on whey this is like this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. or this is actually returning a single column DataFrame right? can you assert that |
||
|
||
ts = df['B'].iloc[2] | ||
assert ts == grouped.last()['B'].iloc[0] | ||
assert ts == grouped.apply(lambda x: x.iloc[-1])[0] | ||
# FIXME: the next assertion is wrong; GH#26864 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. also ok with moving these to a new test if easier |
||
assert ts == grouped.apply(lambda x: x.iloc[-1]).iloc[0, 0] | ||
|
||
|
||
def test_sum_uint64_overflow(): | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be elif