Skip to content

CLN: Fix typos (mainly in docs and comments) #27007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2019
Merged

CLN: Fix typos (mainly in docs and comments) #27007

merged 1 commit into from
Jun 24, 2019

Conversation

minho42
Copy link
Contributor

@minho42 minho42 commented Jun 23, 2019

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@topper-123
Copy link
Contributor

Very nice patch! It needs a rebase, so ping when green.

@topper-123 topper-123 added this to the 0.25.0 milestone Jun 23, 2019
@TomAugspurger
Copy link
Contributor

FYI, it may be easier to split this into smaller pieces, to avoid merge conflicts like the one that came up.

@datapythonista datapythonista changed the title Fix typo CLN: Fix typos (mainly in docs and comments) Jun 24, 2019
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @minho42, nice clean up.

Let us know if you need help resolving the conflicts.

Fix typo
@minho42
Copy link
Contributor Author

minho42 commented Jun 24, 2019

I tried to rebase, but not sure if it's okay.
Please change/amend further if necessary.

@datapythonista
Copy link
Member

Looks ok, let's wait until the CI finishes, but this should be ready to be merged. Thanks @minho42

@codecov
Copy link

codecov bot commented Jun 24, 2019

Codecov Report

Merging #27007 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27007      +/-   ##
==========================================
- Coverage   91.99%   91.99%   -0.01%     
==========================================
  Files         180      180              
  Lines       50774    50774              
==========================================
- Hits        46711    46708       -3     
- Misses       4063     4066       +3
Flag Coverage Δ
#multiple 90.63% <100%> (ø) ⬆️
#single 41.85% <0%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/json/normalize.py 96.93% <ø> (ø) ⬆️
pandas/core/arrays/period.py 98.54% <ø> (ø) ⬆️
pandas/plotting/_matplotlib/tools.py 78.53% <ø> (ø) ⬆️
pandas/core/dtypes/common.py 96.35% <ø> (ø) ⬆️
pandas/util/testing.py 90.94% <ø> (+0.1%) ⬆️
pandas/core/indexes/interval.py 96.44% <ø> (ø) ⬆️
pandas/core/resample.py 97.23% <ø> (ø) ⬆️
pandas/tseries/offsets.py 96.36% <ø> (ø) ⬆️
pandas/core/indexes/datetimes.py 96.37% <ø> (ø) ⬆️
pandas/core/indexes/base.py 96.92% <ø> (ø) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf74b02...2acac6e. Read the comment docs.

@datapythonista datapythonista merged commit 83fe8d7 into pandas-dev:master Jun 24, 2019
@datapythonista
Copy link
Member

Thanks @minho42

@minho42 minho42 deleted the Fix-typo branch June 24, 2019 15:56
Viktor-Demin added a commit to Viktor-Demin/pandas that referenced this pull request Jun 24, 2019
CLN: Fix typos (mainly in docs and comments) (pandas-dev#27007)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants