-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CLN: Fix typos (mainly in docs and comments) #27007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Very nice patch! It needs a rebase, so ping when green. |
FYI, it may be easier to split this into smaller pieces, to avoid merge conflicts like the one that came up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @minho42, nice clean up.
Let us know if you need help resolving the conflicts.
I tried to rebase, but not sure if it's okay. |
Looks ok, let's wait until the CI finishes, but this should be ready to be merged. Thanks @minho42 |
Codecov Report
@@ Coverage Diff @@
## master #27007 +/- ##
==========================================
- Coverage 91.99% 91.99% -0.01%
==========================================
Files 180 180
Lines 50774 50774
==========================================
- Hits 46711 46708 -3
- Misses 4063 4066 +3
Continue to review full report at Codecov.
|
Thanks @minho42 |
CLN: Fix typos (mainly in docs and comments) (pandas-dev#27007)
git diff upstream/master -u -- "*.py" | flake8 --diff