Skip to content

xfail test_missing_required_dependency test #26993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2019

Conversation

TomAugspurger
Copy link
Contributor

See MacPython/pandas-wheels#50. I can't get this test to work reliably.

Setting PYTHONPATH to include a dir with these libs breaks
the test. We use -E to disable that.

Closes pandas-dev#26983
@TomAugspurger TomAugspurger added this to the 0.25.0 milestone Jun 21, 2019
@TomAugspurger TomAugspurger added the CI Continuous Integration label Jun 21, 2019
@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #26993 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26993      +/-   ##
==========================================
- Coverage   91.99%   91.98%   -0.01%     
==========================================
  Files         180      180              
  Lines       50774    50774              
==========================================
- Hits        46711    46707       -4     
- Misses       4063     4067       +4
Flag Coverage Δ
#multiple 90.63% <ø> (ø) ⬆️
#single 41.85% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 171615a...2961aa2. Read the comment docs.

@jreback jreback merged commit a14874f into pandas-dev:master Jun 21, 2019
@jreback
Copy link
Contributor

jreback commented Jun 21, 2019

cool, thanks @TomAugspurger

@jbrockmendel
Copy link
Member

AFAICT this is resolved by using sys.executable instead of hard-coding "python"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants