Skip to content

BLD: wheel building is failing #26983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jreback opened this issue Jun 21, 2019 · 4 comments
Closed

BLD: wheel building is failing #26983

jreback opened this issue Jun 21, 2019 · 4 comments
Labels
Blocker Blocking issue or pull request for an upcoming release Build Library building on various platforms
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Jun 21, 2019

after the latest round of merges, seems wheel buidling is failing:

https://travis-ci.org/MacPython/pandas-wheels/builds/548526771

=================================== FAILURES ===================================
_______________________ test_missing_required_dependency _______________________
[gw1] linux -- Python 3.5.5 /venv/bin/python
    def test_missing_required_dependency():
        # GH 23868
        # use the -S flag to disable site-packages
        call = ['python', '-S', '-c', 'import pandas']
    
        with pytest.raises(subprocess.CalledProcessError) as exc:
            subprocess.check_output(call, stderr=subprocess.STDOUT)
    
        output = exc.value.stdout.decode()
>       assert all(x in output for x in ['numpy', 'pytz', 'dateutil'])
E       assert False
E        +  where False = all(<generator object test_missing_required_dependency.<locals>.<genexpr> at 0x7f6e59bd4c50>)
/venv/lib/python3.5/site-packages/pandas/tests/test_downstream.py:145: AssertionError
=============================== warnings summary ===============================
@jreback jreback added Build Library building on various platforms Blocker Blocking issue or pull request for an upcoming release labels Jun 21, 2019
@jreback jreback added this to the 0.25.0 milestone Jun 21, 2019
@jreback
Copy link
Contributor Author

jreback commented Jun 21, 2019

cc @TomAugspurger

@TomAugspurger
Copy link
Contributor

Taking a look now.

TomAugspurger added a commit to TomAugspurger/pandas that referenced this issue Jun 21, 2019
Setting PYTHONPATH to include a dir with these libs breaks
the test. We use -E to disable that.

Closes pandas-dev#26983
@TomAugspurger
Copy link
Contributor

So, this test fails if the PYTHONPATH is set to include site packages.

PYTHONPATH=/Users/taugspurger/Envs/pandas-dev/lib/python3.7/site-packages/ pytest pandas/tests/test_downstream.py::test_missing_required_dependency

The fix is to use the -E flag, for the subprocess call, to disable PYTHONPATH lookup. Will test out over there, and fixup here.

TomAugspurger added a commit to TomAugspurger/pandas that referenced this issue Jun 21, 2019
Setting PYTHONPATH to include a dir with these libs breaks
the test. We use -E to disable that.

Closes pandas-dev#26983
@TomAugspurger
Copy link
Contributor

This was "fixed" by skipping that test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker Blocking issue or pull request for an upcoming release Build Library building on various platforms
Projects
None yet
Development

No branches or pull requests

2 participants