Skip to content

BLD: fix build error for PyPy on macOS (#26536) #26862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2019
Merged

BLD: fix build error for PyPy on macOS (#26536) #26862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53b4382
BLD: fix build error for PyPy (#26536)
robbuckley Jun 14, 2019
3202409
fix line-splitting style
robbuckley Jun 16, 2019
1398e30
whatsnew entry
robbuckley Jun 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions doc/source/whatsnew/v0.25.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,6 +736,11 @@ Sparse
- Bug in :class:`SparseDataFrame` when adding a column in which the length of values does not match length of index, ``AssertionError`` is raised instead of raising ``ValueError`` (:issue:`25484`)
- Introduce a better error message in :meth:`Series.sparse.from_coo` so it returns a ``TypeError`` for inputs that are not coo matrices (:issue:`26554`)

Build Changes
^^^^^^^^^^^^^

- Fix install error with PyPy on macOS (:issue:`26536`)

Other
^^^^^

Expand Down
18 changes: 9 additions & 9 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

import pkg_resources
import platform
from distutils.sysconfig import get_config_var
from distutils.sysconfig import get_config_vars
import sys
import shutil
from distutils.version import LooseVersion
Expand Down Expand Up @@ -442,19 +442,19 @@ def run(self):
if debugging_symbols_requested:
extra_compile_args.append('-g')

# For mac, ensure extensions are built for macos 10.9 when compiling on a
# 10.9 system or above, overriding distuitls behaviour which is to target
# the version that python was built for. This may be overridden by setting
# Build for at least macOS 10.9 when compiling on a 10.9 system or above,
# overriding CPython distuitls behaviour which is to target the version that
# python was built for. This may be overridden by setting
# MACOSX_DEPLOYMENT_TARGET before calling setup.py
if is_platform_mac():
if 'MACOSX_DEPLOYMENT_TARGET' not in os.environ:
current_system = LooseVersion(platform.mac_ver()[0])
python_target = LooseVersion(
get_config_var('MACOSX_DEPLOYMENT_TARGET'))
if python_target < '10.9' and current_system >= '10.9':
current_system = platform.mac_ver()[0]
python_target = get_config_vars().get('MACOSX_DEPLOYMENT_TARGET',
current_system)
if (LooseVersion(python_target) < '10.9' and
LooseVersion(current_system) >= '10.9'):
os.environ['MACOSX_DEPLOYMENT_TARGET'] = '10.9'


# enable coverage by building cython files by setting the environment variable
# "PANDAS_CYTHON_COVERAGE" (with a Truthy value) or by running build_ext
# with `--with-cython-coverage`enabled
Expand Down