BLD: fix build error for PyPy on macOS (#26536) #26862
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26862 +/- ##
==========================================
- Coverage 91.88% 91.87% -0.01%
==========================================
Files 179 179
Lines 50696 50696
==========================================
- Hits 46581 46576 -5
- Misses 4115 4120 +5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26862 +/- ##
==========================================
- Coverage 91.88% 91.86% -0.02%
==========================================
Files 179 180 +1
Lines 50696 50710 +14
==========================================
+ Hits 46581 46584 +3
- Misses 4115 4126 +11
Continue to review full report at Codecov.
|
|
Thanks for the work! I'm testing this. Just to be sure, am I correct that pandas already dropped support for Python 2? |
|
@robbuckley I've commented the line that needs minor fix ( Thank you! |
|
Yes, py2 has been dropped. |
robbuckley
force-pushed
the
fix-pypy-build
branch
from
85ed4f8 to
53b4382
Compare
|
@bhy thanks for testing, and pointing out the issue. I've fixed it in a slightly different way - would you mind giving the new code a check to make sure it installs with PyPy? thanks! |
|
@robbuckley I tested again. Now installation works without any problem on PyPy. Thanks! |
robbuckley
changed the title
|
lgtm ex @TomAugspurger comment. ping on green. |
|
all done |
|
@robbuckley does this pass on the wheel building? if you can test |
|
Seems easier to merge first and verify?
…On Mon, Jun 17, 2019 at 6:39 AM Jeff Reback ***@***.***> wrote:
@robbuckley <https://github.com/robbuckley> does this pass on the wheel
building? if you can test
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26862?email_source=notifications&email_token=AAKAOIRKSHL2HDQRS4FIRV3P25ZX7A5CNFSM4HYNVBD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX24VIA#issuecomment-502647456>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKAOIXZ2STPQQ7H2WOP7DLP25ZX7ANCNFSM4HYNVBDQ>
.
|
|
I should be able to run the wheel builder script tomorrow. |
|
thanks @robbuckley that would be great |
|
I ran the daily wheelbuilder on my fork, all passed. But them I realised that the changed code would not have been executed under the wheel builder scripts, thanks to: since the changes are inside a check for: So I pip installed the 3 macOS wheels built off my fork in suitable environments. That at least ensures the changed code has been executed. That plus @bhy's check that the PyPy issue seems to be fixed should be enough. |
|
@robbuckley do we need < 10.9 supported any longer? (for going forwards in 0.25.0), I don't remember why we needed that in the first place. |
|
@jreback we need it to build Python 3.5 wheels, since python.org don’t provide a 10’9 version of that |
|
@robbuckley so reading your comments, this is good to go and pandas-wheels doesn't need any changing? |
|
Yes, that’s right. I have a PR pending in pandas-wheels, but it’s independent of this one |
|
thanks @robbuckley ping us on pandas-wheels for the PR |
git diff upstream/master -u -- "*.py" | flake8 --diffThis change should have no effect on CPython, and may fix a crash in when trying to install using PyPy (see #26536).
I've given this a very quick check by installing locally with
pip install -e(cpython 3.6 on mac). I dont have an easy way to check it on PyPy, so Im hoping the OP from #26536 can do this (@bhy)