Skip to content

Remove isort dep #26741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2019
Merged

Remove isort dep #26741

merged 1 commit into from
Jun 8, 2019

Conversation

alimcmaster1
Copy link
Member

@alimcmaster1 alimcmaster1 mentioned this pull request Jun 8, 2019
Merged
3 tasks
@jreback jreback added the Testing pandas testing functions or related to the test suite label Jun 8, 2019
@jreback jreback added this to the 0.25.0 milestone Jun 8, 2019
@jreback
Copy link
Contributor

jreback commented Jun 8, 2019

lgtm. merge on green.

@codecov
Copy link

codecov bot commented Jun 8, 2019

Codecov Report

Merging #26741 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26741      +/-   ##
==========================================
- Coverage   91.78%   91.77%   -0.01%     
==========================================
  Files         174      174              
  Lines       50703    50703              
==========================================
- Hits        46538    46534       -4     
- Misses       4165     4169       +4
Flag Coverage Δ
#multiple 90.37% <ø> (ø) ⬆️
#single 41.81% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.88% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3937fbc...7edcf92. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 8, 2019 •
edited
Loading

Codecov Report

Merging #26741 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26741      +/-   ##
==========================================
- Coverage   91.78%   91.77%   -0.01%     
==========================================
  Files         174      174              
  Lines       50703    50703              
==========================================
- Hits        46538    46534       -4     
- Misses       4165     4169       +4
Flag Coverage Δ
#multiple 90.37% <ø> (ø) ⬆️
#single 41.81% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.88% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3937fbc...7edcf92. Read the comment docs.

@jreback jreback merged commit caed313 into pandas-dev:master Jun 8, 2019
@jreback
Copy link
Contributor

jreback commented Jun 8, 2019

thanks @alimcmaster1

@alimcmaster1 alimcmaster1 deleted the mcmali-dev branch December 25, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alimcmaster1 @jreback