-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Remove isort dep #26732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove isort dep #26732
Conversation
closed and re-opened the PR since Travis doesn't seem to run on draft PRs |
Codecov Report
@@ Coverage Diff @@
## master #26732 +/- ##
==========================================
- Coverage 91.78% 91.77% -0.01%
==========================================
Files 174 174
Lines 50703 50703
==========================================
- Hits 46538 46534 -4
- Misses 4165 4169 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26732 +/- ##
==========================================
- Coverage 91.78% 91.77% -0.01%
==========================================
Files 174 174
Lines 50703 50703
==========================================
- Hits 46538 46534 -4
- Misses 4165 4169 +4
Continue to review full report at Codecov.
|
so we don't actually need isort in any of the ci/* .yml files, only in environment.yml, can you remove to all. |
yep sorry added the ones I missed thanks @jreback |
thanks ! |
hmm one more: |
aah! #26741 |
#LondonPythonSprints
cc @datapythonista