Skip to content

Remove isort dep #26732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2019
Merged

Remove isort dep #26732

merged 2 commits into from
Jun 8, 2019

Conversation

alimcmaster1
Copy link
Member

@alimcmaster1 alimcmaster1 commented Jun 8, 2019

#LondonPythonSprints

cc @datapythonista

@simonjayhawkins simonjayhawkins added CI Continuous Integration Dependencies Required and optional dependencies labels Jun 8, 2019
@alimcmaster1 alimcmaster1 mentioned this pull request Jun 8, 2019
3 tasks
@alimcmaster1 alimcmaster1 marked this pull request as ready for review June 8, 2019 13:30
@alimcmaster1 alimcmaster1 reopened this Jun 8, 2019
@alimcmaster1
Copy link
Member Author

closed and re-opened the PR since Travis doesn't seem to run on draft PRs

@alimcmaster1 alimcmaster1 changed the title WIP: Remove isort dep Remove isort dep Jun 8, 2019
@codecov
Copy link

codecov bot commented Jun 8, 2019

Codecov Report

Merging #26732 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26732      +/-   ##
==========================================
- Coverage   91.78%   91.77%   -0.01%     
==========================================
  Files         174      174              
  Lines       50703    50703              
==========================================
- Hits        46538    46534       -4     
- Misses       4165     4169       +4
Flag Coverage Δ
#multiple 90.37% <ø> (ø) ⬆️
#single 41.81% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.88% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf25c5c...e518346. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 8, 2019

Codecov Report

Merging #26732 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26732      +/-   ##
==========================================
- Coverage   91.78%   91.77%   -0.01%     
==========================================
  Files         174      174              
  Lines       50703    50703              
==========================================
- Hits        46538    46534       -4     
- Misses       4165     4169       +4
Flag Coverage Δ
#multiple 90.37% <ø> (ø) ⬆️
#single 41.81% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.88% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf25c5c...1f52b34. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Jun 8, 2019

so we don't actually need isort in any of the ci/* .yml files, only in environment.yml, can you remove to all.

@jreback jreback added this to the 0.25.0 milestone Jun 8, 2019
@alimcmaster1
Copy link
Member Author

yep sorry added the ones I missed thanks @jreback

@jreback jreback merged commit 3937fbc into pandas-dev:master Jun 8, 2019
@jreback
Copy link
Contributor

jreback commented Jun 8, 2019

thanks !

@jreback
Copy link
Contributor

jreback commented Jun 8, 2019

hmm one more:
ci/deps/travis-36-doc.yaml: - isort

@alimcmaster1 alimcmaster1 mentioned this pull request Jun 8, 2019
@alimcmaster1
Copy link
Member Author

aah! #26741

@alimcmaster1 alimcmaster1 deleted the mcmali-removedep branch December 25, 2019 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Remove isort from CI dependencies
3 participants