-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: remove Panel-specific parts of core.generic #26738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26738 +/- ##
==========================================
+ Coverage 91.78% 91.79% +<.01%
==========================================
Files 174 174
Lines 50703 50695 -8
==========================================
- Hits 46538 46533 -5
+ Misses 4165 4162 -3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26738 +/- ##
==========================================
+ Coverage 91.78% 91.78% +<.01%
==========================================
Files 174 174
Lines 50703 50683 -20
==========================================
- Hits 46538 46521 -17
+ Misses 4165 4162 -3
Continue to review full report at Codecov.
|
if self.ndim > 2: | ||
raise NotImplementedError( | ||
"_is_level_reference is not implemented for {type}" | ||
.format(type=type(self))) | ||
|
||
axis = self._get_axis_number(axis) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually I wouldn't worry about checking ndim at all in any methods and just remove all of the checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good. thanks.
Thanks, @simonjayhawkins! |
xref #25632
removed small amount of code related to self.ndim > 2
also a few changes to make the NotImplemented errors for self.ndim>2 more consistent and added test for these. (might be worth having a decorator for these)