Skip to content

CLN: remove Panel-specific parts of core.generic #26738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 9, 2019

Conversation

simonjayhawkins
Copy link
Member

xref #25632

removed small amount of code related to self.ndim > 2

also a few changes to make the NotImplemented errors for self.ndim>2 more consistent and added test for these. (might be worth having a decorator for these)

@codecov
Copy link

codecov bot commented Jun 8, 2019

Codecov Report

Merging #26738 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26738      +/-   ##
==========================================
+ Coverage   91.78%   91.79%   +<.01%     
==========================================
  Files         174      174              
  Lines       50703    50695       -8     
==========================================
- Hits        46538    46533       -5     
+ Misses       4165     4162       -3
Flag Coverage Δ
#multiple 90.38% <100%> (+0.01%) ⬆️
#single 41.81% <0%> (-0.08%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 93.94% <100%> (+0.3%) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.88% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6fdb6b...ff2747d. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 8, 2019

Codecov Report

Merging #26738 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26738      +/-   ##
==========================================
+ Coverage   91.78%   91.78%   +<.01%     
==========================================
  Files         174      174              
  Lines       50703    50683      -20     
==========================================
- Hits        46538    46521      -17     
+ Misses       4165     4162       -3
Flag Coverage Δ
#multiple 90.38% <100%> (+0.01%) ⬆️
#single 41.82% <0%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 93.91% <100%> (+0.27%) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.88% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3937fbc...a2cedd7. Read the comment docs.

if self.ndim > 2:
raise NotImplementedError(
"_is_level_reference is not implemented for {type}"
.format(type=type(self)))

axis = self._get_axis_number(axis)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually I wouldn't worry about checking ndim at all in any methods and just remove all of the checks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good. thanks.

@topper-123 topper-123 merged commit a387110 into pandas-dev:master Jun 9, 2019
@topper-123
Copy link
Contributor

Thanks, @simonjayhawkins!

@simonjayhawkins simonjayhawkins deleted the core-generic branch June 10, 2019 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants