Skip to content

CLN: final Panel cleanup #25632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
jreback opened this issue Mar 10, 2019 · 7 comments · Fixed by #27101
Closed
1 task

CLN: final Panel cleanup #25632

jreback opened this issue Mar 10, 2019 · 7 comments · Fixed by #27101
Labels
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Mar 10, 2019

I think we can take the final step an remove all remaining references to Panel.

(pandas) bash-3.2$ grep -r Panel pandas --exclude '*.pickle' --exclude *.msgpack --include '*.py' |wc
     146     911   11617

note that the pickle & msgpack files will stay.

TODO

  • Have _constructor_expanddim raise a Notimplementederror
@jreback
Copy link
Contributor Author

jreback commented Jun 3, 2019

anything left on this

cc @pandas-dev/pandas-core

@datapythonista
Copy link
Member

I opened #26627, I couldn't find anything else.

@jbrockmendel
Copy link
Member

Were the pickle/msgpack files ever recreated without Panel?

@WillAyd
Copy link
Member

WillAyd commented Jun 3, 2019

@jbrockmendel is that all we need to do is basically re-save those test files?

@jbrockmendel
Copy link
Member

is that all we need to do is basically re-save those test files?

Using the older pandas versions, yah. When I tried to do this a few months ago it didn't go great, don't remember off the top of my head what went wrong.

@jbrockmendel
Copy link
Member

@WillAyd #25250

@simonjayhawkins
Copy link
Member

there seems a small bit of panel specific code in to_xarray in core.generic.

it's not tested for self.ndim> 2, ok to remove?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants