Skip to content

[TST] Fix test_quantile_interpolation_int #26633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2019
Merged

[TST] Fix test_quantile_interpolation_int #26633

merged 2 commits into from
Jun 5, 2019

Conversation

makbigc
Copy link
Contributor

@makbigc makbigc commented Jun 3, 2019

Follow up #26556 (comment)

@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

Merging #26633 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26633      +/-   ##
==========================================
- Coverage   91.88%   91.87%   -0.01%     
==========================================
  Files         174      174              
  Lines       50692    50692              
==========================================
- Hits        46576    46572       -4     
- Misses       4116     4120       +4
Flag Coverage Δ
#multiple 90.41% <ø> (ø) ⬆️
#single 41.8% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d124ea...7cb9883. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 3, 2019 •
edited
Loading

Codecov Report

Merging #26633 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26633      +/-   ##
==========================================
- Coverage   91.88%   91.87%   -0.01%     
==========================================
  Files         174      174              
  Lines       50692    50692              
==========================================
- Hits        46576    46572       -4     
- Misses       4116     4120       +4
Flag Coverage Δ
#multiple 90.41% <ø> (ø) ⬆️
#single 41.8% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d124ea...715f4ae. Read the comment docs.

@WillAyd
Copy link
Member

WillAyd commented Jun 3, 2019

Based off test name it looks like the TODO comment here is to add interpolation='linear' to q1 - any reason not to do that instead of removing?

@simonjayhawkins

@WillAyd WillAyd added Clean Testing pandas testing functions or related to the test suite labels Jun 3, 2019
simonjayhawkins
simonjayhawkins requested changes Jun 3, 2019
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WillAyd That's correct, the bad test needs fixing, not the code removing.

@makbigc makbigc changed the title [CLN] Remove duplicate code in frame/test_quantile.py [CLN] Fix test_quantile_interpolation_int Jun 4, 2019
@makbigc makbigc changed the title [CLN] Fix test_quantile_interpolation_int [TST] Fix test_quantile_interpolation_int Jun 4, 2019
gfyoung
gfyoung approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonjayhawkins if you can have a look

WillAyd
WillAyd approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as well merge when satisfied @simonjayhawkins

@WillAyd WillAyd added this to the 0.25.0 milestone Jun 5, 2019
@simonjayhawkins simonjayhawkins merged commit 01d97d4 into pandas-dev:master Jun 5, 2019
@simonjayhawkins
Copy link
Member

Thanks @makbigc

vaibhavhrt pushed a commit to vaibhavhrt/pandas that referenced this pull request Jun 6, 2019
@makbigc @vaibhavhrt
[TST] Fix test_quantile_interpolation_int (pandas-dev#26633)
7370c1d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

@gfyoung gfyoung gfyoung approved these changes

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@makbigc @WillAyd @simonjayhawkins @gfyoung