Skip to content

TST/CLN: Fixturize tests/frame/test_quantile.py #26556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 1, 2019

Conversation

makbigc
Copy link
Contributor

@makbigc makbigc commented May 29, 2019

@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #26556 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26556      +/-   ##
==========================================
- Coverage   91.77%   91.76%   -0.01%     
==========================================
  Files         174      174              
  Lines       50649    50649              
==========================================
- Hits        46483    46479       -4     
- Misses       4166     4170       +4
Flag Coverage Δ
#multiple 90.3% <ø> (ø) ⬆️
#single 41.69% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7ad884...f26f574. Read the comment docs.

@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #26556 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26556      +/-   ##
==========================================
- Coverage   91.84%   91.84%   -0.01%     
==========================================
  Files         174      174              
  Lines       50643    50644       +1     
==========================================
- Hits        46515    46512       -3     
- Misses       4128     4132       +4
Flag Coverage Δ
#multiple 90.37% <ø> (ø) ⬆️
#single 41.71% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️
pandas/plotting/_compat.py 84.61% <0%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a60d1bd...ad6a5d8. Read the comment docs.

@simonjayhawkins simonjayhawkins added Clean Testing pandas testing functions or related to the test suite labels May 29, 2019
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@makbigc Thanks for the PR. a couple of suggestions.

@simonjayhawkins
Copy link
Member

@makbigc does this close #22471?

@makbigc
Copy link
Contributor Author

makbigc commented May 30, 2019

Yes, close one of the issues there

@simonjayhawkins
Copy link
Member

Yes, close one of the issues there

OK, have changed to xref #22471.

@makbigc makbigc force-pushed the fixturize_frame_quantile branch from 666f688 to ecb0bbb Compare May 30, 2019 15:54
@simonjayhawkins simonjayhawkins added this to the 0.25.0 milestone May 30, 2019
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@makbigc lgtm. just the comment regarding the TODO.

Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jreback jreback merged commit 4ec92eb into pandas-dev:master Jun 1, 2019
@jreback
Copy link
Contributor

jreback commented Jun 1, 2019

thanks @makbigc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants