Skip to content

remove outdated gtk package from code #26590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 2, 2019
Merged

remove outdated gtk package from code #26590

merged 5 commits into from
Jun 2, 2019

Conversation

xcz011
Copy link
Contributor

@xcz011 xcz011 commented May 31, 2019 •
edited
Loading

@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #26590 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26590      +/-   ##
==========================================
+ Coverage   91.84%   91.85%   +0.01%     
==========================================
  Files         174      174              
  Lines       50644    50629      -15     
==========================================
- Hits        46515    46507       -8     
+ Misses       4129     4122       -7
Flag Coverage Δ
#multiple 90.39% <100%> (+0.01%) ⬆️
#single 41.71% <100%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/clipboards.py 100% <ø> (ø) ⬆️
pandas/io/clipboard/clipboards.py 34.78% <ø> (+3.13%) ⬆️
pandas/core/generic.py 93.62% <ø> (ø) ⬆️
pandas/io/clipboard/__init__.py 54.34% <100%> (-2.52%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.91% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0041935...3c1dfa8. Read the comment docs.

@codecov
Copy link

codecov bot commented May 31, 2019 •
edited
Loading

Codecov Report

Merging #26590 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26590      +/-   ##
==========================================
+ Coverage   91.84%   91.86%   +0.01%     
==========================================
  Files         174      174              
  Lines       50644    50692      +48     
==========================================
+ Hits        46515    46569      +54     
+ Misses       4129     4123       -6
Flag Coverage Δ
#multiple 90.4% <100%> (+0.02%) ⬆️
#single 41.76% <100%> (-0.02%) ⬇️
Impacted Files Coverage Δ
pandas/io/clipboards.py 100% <ø> (ø) ⬆️
pandas/io/clipboard/clipboards.py 34.78% <ø> (+3.13%) ⬆️
pandas/core/generic.py 93.62% <ø> (ø) ⬆️
pandas/io/clipboard/__init__.py 54.34% <100%> (-2.52%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️
pandas/core/arrays/categorical.py 95.92% <0%> (+0.01%) ⬆️
pandas/io/formats/excel.py 97.44% <0%> (+0.04%) ⬆️
pandas/core/indexes/multi.py 95.67% <0%> (+0.04%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0041935...b9c001f. Read the comment docs.

WillAyd
WillAyd requested changes May 31, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good

pandas/io/clipboard/__init__.py Outdated
qtpy also requires a python-qt-bindings module: PyQt4, PyQt5, PySide, PySide2

gtk and PyQt4 modules are not available for Python 3,
PyQt4 modules are not available for Python 3,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm is this still true for PyQt4? We only support Python3 now so if another package doesn’t it wouldn’t make sense to keep including in the code base

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By looking at PyQt4 document https://www.riverbankcomputing.com/static/Docs/PyQt4/python_v3.html, they seems support python 3, so I am going remove this comment.

@WillAyd WillAyd added the Clean label May 31, 2019
@WillAyd
Copy link
Member

WillAyd commented Jun 1, 2019

Lgtm @jreback

@jreback jreback added this to the 0.25.0 milestone Jun 1, 2019
jreback
jreback requested changes Jun 1, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a note in the whatsnew (api changes) that we removed support for gtk for clipboards. ping on green.

@xcz011
Copy link
Contributor Author

xcz011 commented Jun 2, 2019

can you add a note in the whatsnew (api changes) that we removed support for gtk for clipboards. ping on green.

Hi @jreback just added 😄

@jreback jreback merged commit 3355291 into pandas-dev:master Jun 2, 2019
@jreback
Copy link
Contributor

jreback commented Jun 2, 2019

thanks @xcz011

vaibhavhrt pushed a commit to vaibhavhrt/pandas that referenced this pull request Jun 6, 2019
@xcz011 @vaibhavhrt
remove outdated gtk package from code (pandas-dev#26590)
6fb0be0
@krey krey mentioned this pull request Sep 16, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

Remove gtk imports from codebase
3 participants
@xcz011 @WillAyd @jreback