Skip to content

Remove gtk imports from codebase #26563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
WillAyd opened this issue May 29, 2019 · 1 comment · Fixed by #26590
Closed

Remove gtk imports from codebase #26563

WillAyd opened this issue May 29, 2019 · 1 comment · Fixed by #26590
Labels
Clean Dependencies Required and optional dependencies good first issue
Milestone
0.25.0

Comments

@WillAyd
Copy link
Member

WillAyd commented May 29, 2019

We have a few "import gtk" imports in the clipboards part of the code base but I cannot find any information as to what these actually are, so I assume these are especially outdated given our drop of Py27 support.

I think this used to be a part of PyGTK, but links to that (like http://www.pygtk.org/) seem to redirect now to PyGObject which has different import machinery anyway
@WillAyd WillAyd added 2/3 Compat Clean Dependencies Required and optional dependencies good first issue labels May 29, 2019
@xcz011 xcz011 mentioned this issue May 31, 2019
Merged
4 tasks
@xcz011
Copy link
Contributor

xcz011 commented May 31, 2019

Hi @WillAyd, I just give a PR, and hope I understand you correctly. If not, please feel free to correct me. Thanks.

@jreback jreback added this to the 0.25.0 milestone Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean Dependencies Required and optional dependencies good first issue
Projects
None yet
Milestone
0.25.0
Development

Successfully merging a pull request may close this issue.

remove outdated gtk package from code
3 participants
@WillAyd @jreback @xcz011