Skip to content

TST/CLN: remove try/except from test_column_contains_typeerror #26442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2019
Merged

TST/CLN: remove try/except from test_column_contains_typeerror #26442

merged 1 commit into from
May 18, 2019

Conversation

simonjayhawkins
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 17, 2019 •
edited
Loading

Codecov Report

Merging #26442 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26442      +/-   ##
==========================================
- Coverage   91.73%   91.72%   -0.01%     
==========================================
  Files         174      174              
  Lines       50738    50738              
==========================================
- Hits        46545    46541       -4     
- Misses       4193     4197       +4
Flag Coverage Δ
#multiple 90.23% <ø> (ø) ⬆️
#single 41.7% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe6b91...bd49f7a. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #26442 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26442      +/-   ##
==========================================
- Coverage   91.73%   91.72%   -0.01%     
==========================================
  Files         174      174              
  Lines       50738    50738              
==========================================
- Hits        46545    46541       -4     
- Misses       4193     4197       +4
Flag Coverage Δ
#multiple 90.23% <ø> (ø) ⬆️
#single 41.7% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe6b91...bd49f7a. Read the comment docs.

@gfyoung gfyoung added the Testing pandas testing functions or related to the test suite label May 18, 2019
@gfyoung gfyoung added this to the 0.25.0 milestone May 18, 2019
@gfyoung gfyoung merged commit a7d3cc9 into pandas-dev:master May 18, 2019
@gfyoung
Copy link
Member

gfyoung commented May 18, 2019

Thanks @simonjayhawkins !

@simonjayhawkins simonjayhawkins deleted the test_column_contains_typeerror branch May 18, 2019 01:50
krsnik93 added a commit to krsnik93/pandas that referenced this pull request May 18, 2019
@krsnik93
Revert "TST/CLN: remove try/except from test_column_contains_typeerror (
9f1fab9 
pandas-dev#26442)"

This reverts commit a7d3cc9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@simonjayhawkins @gfyoung