Skip to content

CLN: remove compat.lrange #26396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2019
Merged

CLN: remove compat.lrange #26396

merged 1 commit into from
May 15, 2019

Conversation

topper-123
Copy link
Contributor

@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #26396 into master will decrease coverage by <.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26396      +/-   ##
==========================================
- Coverage   91.69%   91.68%   -0.01%     
==========================================
  Files         174      174              
  Lines       50749    50743       -6     
==========================================
- Hits        46534    46524      -10     
- Misses       4215     4219       +4
Flag Coverage Δ
#multiple 90.19% <85.71%> (-0.01%) ⬇️
#single 41.16% <0%> (-0.16%) ⬇️
Impacted Files Coverage Δ
pandas/compat/__init__.py 93.54% <ø> (-0.4%) ⬇️
pandas/plotting/_converter.py 63.66% <ø> (-0.06%) ⬇️
pandas/plotting/_style.py 76.92% <100%> (-0.26%) ⬇️
pandas/plotting/_core.py 83.89% <100%> (-0.02%) ⬇️
pandas/plotting/_misc.py 38.23% <75%> (-0.23%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5d15b2...ed33b66. Read the comment docs.

@codecov
Copy link

codecov bot commented May 14, 2019 •
edited
Loading

Codecov Report

Merging #26396 into master will decrease coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26396      +/-   ##
==========================================
- Coverage   91.69%   91.68%   -0.02%     
==========================================
  Files         174      174              
  Lines       50749    50743       -6     
==========================================
- Hits        46534    46523      -11     
- Misses       4215     4220       +5
Flag Coverage Δ
#multiple 90.19% <85.71%> (-0.01%) ⬇️
#single 41.16% <0%> (-0.16%) ⬇️
Impacted Files Coverage Δ
pandas/compat/__init__.py 93.54% <ø> (-0.4%) ⬇️
pandas/plotting/_converter.py 63.66% <ø> (-0.06%) ⬇️
pandas/plotting/_style.py 76.92% <100%> (-0.26%) ⬇️
pandas/plotting/_core.py 83.89% <100%> (-0.02%) ⬇️
pandas/plotting/_misc.py 38.23% <75%> (-0.23%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.6% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5d15b2...78d7cb6. Read the comment docs.

@topper-123 topper-123 force-pushed the remove_compat.lrange_IV branch from ed33b66 to 78d7cb6 Compare May 14, 2019 19:27
WillAyd
WillAyd reviewed May 14, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor question but not necessarily a block. I think this looks good - nice work on all of this @topper-123

pandas/tests/internals/test_internals.py
assert_take_ok(mgr, ax, [])
assert_take_ok(mgr, ax, [0, 0, 0])
assert_take_ok(mgr, ax, lrange(mgr.shape[ax]))
assert_take_ok(mgr, ax, indexer=[])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason for adding the keyword here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was just to aid readability, I found the meaning of those lists became easier to understand. Though I see now it hasnt been done in all the function calls.

@WillAyd WillAyd added this to the 0.25.0 milestone May 14, 2019
@gfyoung gfyoung added the Clean label May 15, 2019
@jreback jreback merged commit a738223 into pandas-dev:master May 15, 2019
@jreback
Copy link
Contributor

jreback commented May 15, 2019

thanks @topper-123

@topper-123 topper-123 deleted the remove_compat.lrange_IV branch May 15, 2019 13:04
@jorisvandenbossche jorisvandenbossche mentioned this pull request May 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd left review comments

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@topper-123 @jreback @WillAyd @gfyoung