Skip to content

CLN: remove compat.lrange, part II #26289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2019

Conversation

topper-123
Copy link
Contributor

Second part of the removal of compat.lrange from the code base.

@topper-123 topper-123 force-pushed the clean_lrange_part_II branch from e024490 to f8c822f Compare May 6, 2019 04:44
@codecov
Copy link

codecov bot commented May 6, 2019

Codecov Report

Merging #26289 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26289      +/-   ##
==========================================
- Coverage   91.98%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52374    52374              
==========================================
- Hits        48178    48174       -4     
- Misses       4196     4200       +4
Flag Coverage Δ
#multiple 90.53% <100%> (ø) ⬆️
#single 40.72% <11.11%> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/io/parsers.py 95.84% <100%> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7120725...f8c822f. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 6, 2019

Codecov Report

Merging #26289 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26289      +/-   ##
==========================================
- Coverage   91.98%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52374    52374              
==========================================
- Hits        48178    48174       -4     
- Misses       4196     4200       +4
Flag Coverage Δ
#multiple 90.53% <100%> (ø) ⬆️
#single 40.72% <11.11%> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/io/parsers.py 95.84% <100%> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7120725...f8c822f. Read the comment docs.

@jschendel jschendel added this to the 0.25.0 milestone May 6, 2019
@jreback jreback merged commit 87df599 into pandas-dev:master May 7, 2019
@jreback
Copy link
Contributor

jreback commented May 7, 2019

thanks @topper-123

@topper-123 topper-123 deleted the clean_lrange_part_II branch May 7, 2019 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants