Skip to content

Remove Panel References from Tests #26332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2019

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented May 10, 2019

ref #25632 this removes a good deal of Panel references from tests though not all (excluding anything for msgpack).

I think after this and #25567 get merged we can starting finalizing the Panel removal and get out of docs as well

def test_groupby_multiple_columns(df, op):
data = df
grouped = data.groupby(['A', 'B'])

result1 = op(grouped)

expected = defaultdict(dict)
keys = []
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a little bit more movement on the test than I had hoped for but the original test mentions something of this reshaping to be "a little bit crude" so it may be in order; new test should have the same coverage but with less reshaping

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #26332 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26332      +/-   ##
==========================================
- Coverage   92.04%    91.8%   -0.25%     
==========================================
  Files         175      175              
  Lines       52297    52297              
==========================================
- Hits        48137    48011     -126     
- Misses       4160     4286     +126
Flag Coverage Δ
#multiple 90.35% <ø> (-0.24%) ⬇️
#single 40.72% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/core/panel.py 17.49% <0%> (-17.65%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/generic.py 93.34% <0%> (-0.24%) ⬇️
pandas/core/frame.py 97.01% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee6b131...729edea. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #26332 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26332      +/-   ##
==========================================
- Coverage   92.04%    91.8%   -0.25%     
==========================================
  Files         175      175              
  Lines       52297    52297              
==========================================
- Hits        48137    48011     -126     
- Misses       4160     4286     +126
Flag Coverage Δ
#multiple 90.35% <ø> (-0.24%) ⬇️
#single 40.72% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/core/panel.py 17.49% <0%> (-17.65%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/generic.py 93.34% <0%> (-0.24%) ⬇️
pandas/core/frame.py 97.01% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee6b131...729edea. Read the comment docs.

@jreback jreback added this to the 0.25.0 milestone May 11, 2019
@jreback
Copy link
Contributor

jreback commented May 11, 2019

looks ok, pending CI build issues.

@jreback jreback merged commit 4a30fa5 into pandas-dev:master May 12, 2019
@jreback
Copy link
Contributor

jreback commented May 12, 2019

thanks @WillAyd

@WillAyd WillAyd deleted the panel-test-removal branch January 16, 2020 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants