-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Remove Panel References from Tests #26332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
def test_groupby_multiple_columns(df, op): | ||
data = df | ||
grouped = data.groupby(['A', 'B']) | ||
|
||
result1 = op(grouped) | ||
|
||
expected = defaultdict(dict) | ||
keys = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a little bit more movement on the test than I had hoped for but the original test mentions something of this reshaping to be "a little bit crude" so it may be in order; new test should have the same coverage but with less reshaping
Codecov Report
@@ Coverage Diff @@
## master #26332 +/- ##
==========================================
- Coverage 92.04% 91.8% -0.25%
==========================================
Files 175 175
Lines 52297 52297
==========================================
- Hits 48137 48011 -126
- Misses 4160 4286 +126
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #26332 +/- ##
==========================================
- Coverage 92.04% 91.8% -0.25%
==========================================
Files 175 175
Lines 52297 52297
==========================================
- Hits 48137 48011 -126
- Misses 4160 4286 +126
Continue to review full report at Codecov.
|
looks ok, pending CI build issues. |
thanks @WillAyd |
ref #25632 this removes a good deal of Panel references from tests though not all (excluding anything for msgpack).
I think after this and #25567 get merged we can starting finalizing the Panel removal and get out of docs as well