Skip to content

Add type annotation to config_init #26300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2019
Merged

Add type annotation to config_init #26300

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1feba13
Add type annotation to config_init
gwrome May 6, 2019
4e0b688
Re-trigger test
gwrome May 7, 2019
7b363f6
Remove unused style_backup variable
gwrome May 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@ ignore_errors=True
[mypy-pandas.core.computation.pytables]
ignore_errors=True

[mypy-pandas.core.config_init]
ignore_errors=True

[mypy-pandas.core.indexes.base]
ignore_errors=True

Expand Down
4 changes: 3 additions & 1 deletion pandas/core/config_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
module is imported, register them here rather then in the module.

"""
from typing import Dict

import pandas._config.config as cf
from pandas._config.config import (
is_bool, is_callable, is_instance_factory, is_int, is_one_of_factory,
Expand Down Expand Up @@ -277,7 +279,7 @@ def use_numexpr_cb(key):
Valid values: False,True
"""

style_backup = dict()
style_backup = dict() # type: Dict
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this variable still needed? I searched the codebase for style_backup, and it doesn't appear anywhere else. It might be some vestigial code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah looks like you can remove it



def table_schema_cb(key):
Expand Down