Add type annotation to config_init #26300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwrome
commented
May 6, 2019
pandas/core/config_init.py
Outdated
| @@ -277,7 +279,7 @@ def use_numexpr_cb(key): | |||
| Valid values: False,True | |||
| """ | |||
|
|
|||
| style_backup = dict() | |||
| style_backup = dict() # type: Dict | |||
There was a problem hiding this comment.
Is this variable still needed? I searched the codebase for style_backup, and it doesn't appear anywhere else. It might be some vestigial code.
There was a problem hiding this comment.
yeah looks like you can remove it
Codecov Report
@@ Coverage Diff @@
## master #26300 +/- ##
==========================================
- Coverage 91.98% 91.98% -0.01%
==========================================
Files 175 175
Lines 52374 52373 -1
==========================================
- Hits 48178 48173 -5
- Misses 4196 4200 +4
Continue to review full report at Codecov.
|
|
lgtm. ping on green. |
|
@jreback The board is green |
|
thanks @gwrome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff