Skip to content

Add explicit imports in top level pandas init as precursor to PR #25940 #26017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ryankarlos
Copy link
Contributor

@ryankarlos ryankarlos changed the title Add explicit imports in top level pandas init as precursor to #25940 Add explicit imports in top level pandas init as precursor to PR #25940 Apr 7, 2019
@ryankarlos
Copy link
Contributor Author

ryankarlos commented Apr 7, 2019

@WillAyd So my understanding is that I need to import explicitly from top level pandas, to allow direct imports from pandas in stata module for those that were throwing errors in original issue #25932
I have just pushed some changes - let me know.

@codecov
Copy link

codecov bot commented Apr 7, 2019

Codecov Report

Merging #26017 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26017      +/-   ##
==========================================
- Coverage   91.82%   91.81%   -0.01%     
==========================================
  Files         175      175              
  Lines       52551    52551              
==========================================
- Hits        48256    48252       -4     
- Misses       4295     4299       +4
Flag Coverage Δ
#multiple 90.38% <ø> (ø) ⬆️
#single 40.72% <ø> (-0.14%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1fee91...54482fa. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 7, 2019

Codecov Report

Merging #26017 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26017      +/-   ##
==========================================
- Coverage   91.82%   91.81%   -0.01%     
==========================================
  Files         175      175              
  Lines       52551    52551              
==========================================
- Hits        48256    48252       -4     
- Misses       4295     4299       +4
Flag Coverage Δ
#multiple 90.38% <ø> (ø) ⬆️
#single 40.72% <ø> (-0.14%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1fee91...4721051. Read the comment docs.

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal here would be to replace the wildcard imports. So instead of keeping the wildcard and duplicating this import you'd replace the former with explicit references to objects

@pep8speaks
Copy link

Hello @ryankarlos! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 59:80: E501 line too long (88 > 79 characters)

@ryankarlos ryankarlos closed this Apr 7, 2019
@ryankarlos ryankarlos deleted the Import_objects_in_toplevel_init_for_stata_module branch April 7, 2019 14:52
@ryankarlos
Copy link
Contributor Author

Just closed this and opened a new PR #26019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants