-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Add explicit imports in top level pandas init as precursor to PR #25940 #26017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit imports in top level pandas init as precursor to PR #25940 #26017
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26017 +/- ##
==========================================
- Coverage 91.82% 91.81% -0.01%
==========================================
Files 175 175
Lines 52551 52551
==========================================
- Hits 48256 48252 -4
- Misses 4295 4299 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26017 +/- ##
==========================================
- Coverage 91.82% 91.81% -0.01%
==========================================
Files 175 175
Lines 52551 52551
==========================================
- Hits 48256 48252 -4
- Misses 4295 4299 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal here would be to replace the wildcard imports. So instead of keeping the wildcard and duplicating this import you'd replace the former with explicit references to objects
Hello @ryankarlos! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
Just closed this and opened a new PR #26019 |
git diff upstream/master -u -- "*.py" | flake8 --diff