Skip to content

Remove pandas.io.stata from Typing Blacklist #25932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
WillAyd opened this issue Mar 31, 2019 · 2 comments
Closed

Remove pandas.io.stata from Typing Blacklist #25932

WillAyd opened this issue Mar 31, 2019 · 2 comments
Labels
good first issue Typing type annotations, mypy/pyright type checking
Milestone
0.25.0

Comments

@WillAyd
Copy link
Member

WillAyd commented Mar 31, 2019

Here's the list of current errors:

pandas/io/stata.py:32: error: Module 'pandas' has no attribute 'DatetimeIndex'
pandas/io/stata.py:32: error: Module 'pandas' has no attribute 'concat'
pandas/io/stata.py:32: error: Module 'pandas' has no attribute 'isna'
pandas/io/stata.py:32: error: Module 'pandas' has no attribute 'to_datetime'
pandas/io/stata.py:32: error: Module 'pandas' has no attribute 'to_timedelta'
pandas/io/stata.py:1730: error: Name 'data_label' already defined on line 1052

For the former we should just use absolute imports instead of pulling from top level pandas object (per discussion in #25923). The last issue I think is just a method shadowing a instance variable which I think can safely be removed
@WillAyd WillAyd added good first issue Typing type annotations, mypy/pyright type checking labels Mar 31, 2019
@WillAyd WillAyd added this to the Contributions Welcome milestone Mar 31, 2019
@ryankarlos
Copy link
Contributor

Ill make a PR for this as well since I've already done similar for #25934 and #25933

This was referenced Mar 31, 2019
Merged
Closed
@ryankarlos ryankarlos mentioned this issue Apr 7, 2019
Merged
4 tasks
@jreback jreback modified the milestones: Contributions Welcome, 0.25.0 Apr 10, 2019
@bashtage
Copy link
Contributor

bashtage commented May 1, 2019

@WillAyd I think this can be closed.

@jreback jreback closed this as completed May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
0.25.0
Development

No branches or pull requests
4 participants
@WillAyd @jreback @bashtage @ryankarlos