Skip to content

[CLN] Remove TypeError in Interval.length #25859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2019

Conversation

makbigc
Copy link
Contributor

@makbigc makbigc commented Mar 24, 2019

Following #25768, remove TypeError in Interval.length, as all endpoints should be comparable now.

@codecov
Copy link

codecov bot commented Mar 24, 2019

Codecov Report

Merging #25859 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25859   +/-   ##
=======================================
  Coverage   91.45%   91.45%           
=======================================
  Files         172      172           
  Lines       52892    52892           
=======================================
  Hits        48373    48373           
  Misses       4519     4519
Flag Coverage Δ
#multiple 90.02% <ø> (ø) ⬆️
#single 41.81% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e0f9a9...0198873. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 24, 2019

Codecov Report

Merging #25859 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25859   +/-   ##
=======================================
  Coverage   91.45%   91.45%           
=======================================
  Files         172      172           
  Lines       52892    52892           
=======================================
  Hits        48373    48373           
  Misses       4519     4519
Flag Coverage Δ
#multiple 90.02% <ø> (ø) ⬆️
#single 41.81% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e0f9a9...0198873. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Mar 24, 2019

why do no tests break? or they were removed in the prior PR?

@jreback jreback added Interval Interval data type Clean labels Mar 24, 2019
@jschendel
Copy link
Member

or they were removed in the prior PR?

Yeah, the test cases for this were removed in #25768, as they were disallowed at the constructor level. The test introduced in #25768 converted the existing failing test cases for Interval.length into failing test cases for the constructor.

@jschendel jschendel merged commit 72f4098 into pandas-dev:master Mar 24, 2019
@jschendel
Copy link
Member

thanks @makbigc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Interval Interval data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants