-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
[BUG] Construction of Interval restricted to numeric/ Timestamp/ Timedelta (#23013) #25768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25768 +/- ##
=======================================
Coverage 91.25% 91.25%
=======================================
Files 172 172
Lines 52965 52965
=======================================
Hits 48335 48335
Misses 4630 4630
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #25768 +/- ##
==========================================
+ Coverage 91.27% 91.27% +<.01%
==========================================
Files 173 173
Lines 53002 53002
==========================================
+ Hits 48375 48376 +1
+ Misses 4627 4626 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The issue itself didn't get much discussion, and I'm not sure if everyone will agree on this behavior, so will be interesting to see what comments arise here. I support this change, as it's consistent with what we allow for arrays, and as a result eliminates some weird Interval
specific corner cases.
pls merge master |
lgtm. @jschendel |
thanks @makbigc |
git diff upstream/master -u -- "*.py" | flake8 --diff