Skip to content

remove eadata #24625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 5, 2019
Merged

remove eadata #24625

merged 2 commits into from
Jan 5, 2019

Conversation

TomAugspurger
Copy link
Contributor

Closes #24565

@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Jan 4, 2019
@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #24625 into master will decrease coverage by <.01%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24625      +/-   ##
==========================================
- Coverage   92.38%   92.38%   -0.01%     
==========================================
  Files         166      166              
  Lines       52395    52391       -4     
==========================================
- Hits        48403    48399       -4     
  Misses       3992     3992
Flag Coverage Δ
#multiple 90.8% <92.3%> (-0.01%) ⬇️
#single 42.99% <65.38%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/series.py 93.56% <0%> (ø) ⬆️
pandas/core/indexes/timedeltas.py 90.22% <100%> (ø) ⬆️
pandas/core/indexes/datetimes.py 96.22% <100%> (ø) ⬆️
pandas/core/indexes/datetimelike.py 98.51% <93.75%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb31b2b...cd09dfd. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 4, 2019 •
edited
Loading

Codecov Report

Merging #24625 into master will decrease coverage by <.01%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24625      +/-   ##
==========================================
- Coverage   92.38%   92.37%   -0.01%     
==========================================
  Files         166      166              
  Lines       52395    52388       -7     
==========================================
- Hits        48403    48396       -7     
  Misses       3992     3992
Flag Coverage Δ
#multiple 90.8% <96.15%> (ø) ⬆️
#single 43% <69.23%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/series.py 93.64% <100%> (+0.08%) ⬆️
pandas/core/indexes/timedeltas.py 90.22% <100%> (ø) ⬆️
pandas/core/indexes/datetimes.py 96.22% <100%> (ø) ⬆️
pandas/core/indexes/datetimelike.py 98.51% <93.75%> (-0.02%) ⬇️
pandas/util/testing.py 88% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb31b2b...a65586d. Read the comment docs.

jbrockmendel
jbrockmendel reviewed Jan 4, 2019
View reviewed changes
@jbrockmendel
Copy link
Member

small comment, otherwise LGTM

@TomAugspurger TomAugspurger merged commit 510afa7 into pandas-dev:master Jan 5, 2019
@TomAugspurger TomAugspurger deleted the remove-eadata branch January 5, 2019 12:35
@jreback jreback added Internals Related to non-user accessible pandas implementation ExtensionArray Extending pandas with custom dtypes or arrays. labels Jan 5, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@TomAugspurger @Pingviinituutti
CLN: Remove _eadata (pandas-dev#24625)
d0a595f 
* remove eadata
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@TomAugspurger @Pingviinituutti
CLN: Remove _eadata (pandas-dev#24625)
14056cf 
* remove eadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@TomAugspurger @jbrockmendel @jreback