Skip to content

Remove DatetimeIndexOpsMixin._eadata #24565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TomAugspurger opened this issue Jan 2, 2019 · 2 comments
Closed

Remove DatetimeIndexOpsMixin._eadata #24565

TomAugspurger opened this issue Jan 2, 2019 · 2 comments
Labels
Datetime Datetime data dtype ExtensionArray Extending pandas with custom dtypes or arrays. Internals Related to non-user accessible pandas implementation
Milestone
0.24.0

Comments

@TomAugspurger
Copy link
Contributor

Should be able to use ._data now.
@TomAugspurger TomAugspurger added the Datetime Datetime data dtype label Jan 2, 2019
@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Jan 2, 2019
@jorisvandenbossche
Copy link
Member

Do we still want to keep both _values and _data ?

@TomAugspurger
Copy link
Contributor Author

We have ._values for sharing code between Series and Index.

That could maybe be transitioned to using .array, though I'm not sure.

@TomAugspurger TomAugspurger mentioned this issue Jan 4, 2019
Merged
@jreback jreback added ExtensionArray Extending pandas with custom dtypes or arrays. Internals Related to non-user accessible pandas implementation labels Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Datetime Datetime data dtype ExtensionArray Extending pandas with custom dtypes or arrays. Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
0.24.0
Development

No branches or pull requests
3 participants
@jreback @jorisvandenbossche @TomAugspurger