REF/TST: use pytest builtin monkeypatch fixture and remove mock fixture #24624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
requested changes
Jan 4, 2019
| # see gh-15337 | ||
| parser = all_parsers | ||
| msg = "Invalid file path or buffer object type" | ||
|
|
||
| class Mock(): |
There was a problem hiding this comment.
Personally would rather just name this Foo so as not to cause confusion with the real Mock class
WillAyd
added
Testing
Codecov Report
@@ Coverage Diff @@
## master #24624 +/- ##
==========================================
- Coverage 92.38% 92.37% -0.01%
==========================================
Files 166 166
Lines 52395 52395
==========================================
- Hits 48403 48402 -1
- Misses 3992 3993 +1
Continue to review full report at Codecov.
|
|
@simonjayhawkins in followup could add a check for |
|
thanks! |
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
…re (pandas-dev#24624) * use monkeypatch * remove mock fixture * rename class
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
…re (pandas-dev#24624) * use monkeypatch * remove mock fixture * rename class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff