REF/TST: mixed use of mock/monkeypatch

[simonjayhawkins]

doubt if this will work as don't have gbq configured locally.

will need to check output of CI.

[WillAyd]

Is the goal here to get rid of the import? We are dropping Py27 for 0.25 onwards so may be able to remove organically.

I suppose by using a lambda we are making more assumptions about the pandas_gbq codebase and how they treat their functions. May or may not make a difference but I'd lean towards just waiting to drop Py27 as part of cleanup

[simonjayhawkins]

@WillAyd we could drop the import in this module by using the mock fixture from conftest.py.

this was to see if we need mock at all and could just use monkeypatch instead of both mock and monkeypatch.

i expect this PR to fail on the parameters, i'll either change the number of inputs or change the lambda to a function with *args and **kwargs.

[codecov]

Codecov Report

Merging #24557 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #24557   +/-   ##
=======================================
  Coverage   92.33%   92.33%           
=======================================
  Files         166      166           
  Lines       52465    52465           
=======================================
  Hits        48442    48442           
  Misses       4023     4023

Flag	Coverage Δ
#multiple	90.75% <ø> (ø)	⬆️
#single	43% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa7cb01...ab496f8. Read the comment docs.

[codecov]

Codecov Report

Merging #24557 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #24557   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files         166      166           
  Lines       52396    52396           
=======================================
  Hits        48403    48403           
  Misses       3993     3993

Flag	Coverage Δ
#multiple	90.8% <ø> (ø)	⬆️
#single	43% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19f715c...72a6c0b. Read the comment docs.

[jreback]

we also have a mock fixture in pandas/conftest.py should remove that too

[WillAyd]

lgtm @jreback

[jreback]

thanks!