Skip to content

Fix 32-bit builds by correctly using intp_t instead of int64_t for numpy.searchsorted result #24621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

qwhelan
Copy link
Contributor

@qwhelan qwhelan commented Jan 4, 2019

See discussion on #24613

@jreback jreback added this to the 0.24.0 milestone Jan 4, 2019
@jreback jreback added the Compat pandas objects compatability with Numpy or Python functions label Jan 4, 2019
@jreback
Copy link
Contributor

jreback commented Jan 4, 2019

thanks @qwhelan ping on green.

@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #24621 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24621   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files         166      166           
  Lines       52396    52396           
=======================================
  Hits        48403    48403           
  Misses       3993     3993
Flag Coverage Δ
#multiple 90.8% <ø> (ø) ⬆️
#single 43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19f715c...13d5ee4. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #24621 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24621   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files         166      166           
  Lines       52396    52396           
=======================================
  Hits        48403    48403           
  Misses       3993     3993
Flag Coverage Δ
#multiple 90.8% <ø> (ø) ⬆️
#single 43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19f715c...13d5ee4. Read the comment docs.

@qwhelan
Copy link
Contributor Author

qwhelan commented Jan 4, 2019

@jreback ping

@jreback jreback merged commit cb31b2b into pandas-dev:master Jan 4, 2019
@jreback
Copy link
Contributor

jreback commented Jan 4, 2019

thanks @qwhelan

@qwhelan qwhelan deleted the fix_32bit branch January 4, 2019 18:41
jreback added a commit to jreback/pandas that referenced this pull request Jan 5, 2019
jreback added a commit that referenced this pull request Jan 5, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BLD: 32-bit builds failing
2 participants