Skip to content

BLD: 32-bit builds failing #24613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jreback opened this issue Jan 4, 2019 · 5 comments · Fixed by #24621
Closed

BLD: 32-bit builds failing #24613

jreback opened this issue Jan 4, 2019 · 5 comments · Fixed by #24621
Labels
32bit 32-bit systems Timezones Timezone data dtype
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Jan 4, 2019

https://travis-ci.org/MacPython/pandas-wheels/jobs/475157492

failing with

Exception ignored in: 'pandas._libs.tslibs.conversion.tz_convert_single'
Traceback (most recent call last):
  File "pandas/_libs/tslibs/conversion.pyx", line 663, in pandas._libs.tslibs.conversion._tz_convert_dst
ValueError: Buffer dtype mismatch, expected 'int64_t' but got 'int'
Traceback (most recent call last):
  File "pandas/_libs/tslibs/conversion.pyx", line 663, in pandas._libs.tslibs.conversion._tz_convert_dst
ValueError: Buffer dtype mismatch, expected 'int64_t' but got 'int'
Exception ignored in: 'pandas._libs.tslibs.conversion.tz_convert_single'
@jreback jreback added Timezones Timezone data dtype 32bit 32-bit systems labels Jan 4, 2019
@jreback jreback added this to the 0.24.0 milestone Jan 4, 2019
@jreback
Copy link
Contributor Author

jreback commented Jan 4, 2019

cc @mroeschke @qwhelan I think the perf enhancement changed this

@jorisvandenbossche
Copy link
Member

I suppose you meant to tag @mroeschke instead of @mrocklin :)

It's about this PR: #24491

@jreback
Copy link
Contributor Author

jreback commented Jan 4, 2019

yep thanks

@qwhelan
Copy link
Contributor

qwhelan commented Jan 4, 2019

@jreback Certainly seems like my PR is to blame - I'll take a look

@qwhelan
Copy link
Contributor

qwhelan commented Jan 4, 2019

So what's happening is:

  • np.searchsorted() always returns a result of type np.intp, which is 32-bit on 32, 64 on 64. It's described as "Integer used for indexing" here: https://docs.scipy.org/doc/numpy-1.13.0/user/basics.types.html
  • int64_t[:] pos needs to be intp_t[:] pos as a result
  • Seems we've always been unable to properly index into an array of size greater than int32 on 32-bit via np.searchsorted. I'm guessing there's no test coverage for something like this, but would be easy to construct a test case for.

Just opened #24621 to implement the above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
32bit 32-bit systems Timezones Timezone data dtype
Projects
None yet
3 participants