-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Fixes additional flake8 issues in whatsnew v0.14.0 #24240 #24342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24342 +/- ##
===========================================
- Coverage 92.28% 43% -49.28%
===========================================
Files 162 162
Lines 51835 51835
===========================================
- Hits 47834 22290 -25544
- Misses 4001 29545 +25544
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24342 +/- ##
==========================================
+ Coverage 92.28% 92.28% +<.01%
==========================================
Files 162 162
Lines 51835 51835
==========================================
+ Hits 47834 47835 +1
+ Misses 4001 4000 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Seuss27 the template we provide in the description of the pull request, helps us know which issue are you addressing, and it closes it automatically when we merge the PR. Instead of deleting it, the idea is that you replace the #xxxxx
by the issue number, and tick all the checkboxes that apply.
For this PR, we need the changes in setup.cfg
that remove the file from the exclusion list, so it's validated.
@datapythonista This file was already processed and removed from setup.cfg, I noticed the compilation errors when I was debugging another rst file. Understood regarding the template and the usage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I see, thanks for clarifying @Seuss27
Next time it makes it easier if you say that in the PR description, and you add the PR number this is a follow up of.
are we not checking? since 0.14. is removed? |
For what I understand, |
thanks @Seuss27 |
Related to #24240
Fixed an indentation error that revealed more flake8 issues.