Skip to content

DOC: Fixes flake8 issues in whatsnew v0.13.* #24256 #24322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Dec 18, 2018

Conversation

Seuss27
Copy link
Contributor

@Seuss27 Seuss27 commented Dec 17, 2018

Added the flake8-group: ignore to fix the intentional E999 errors and
fixed the remaining flake8 issues in v0.13.0.rst
Updated setup.cfg to the most recent version before PR
Added missing space in setup.cfg exclusion section.
@Seuss27
Copy link
Contributor Author

Seuss27 commented Dec 17, 2018

I am not sure if there is anything different I can do with the merge conflict in setup.cfg. Please advise.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes, just added a few comments. Also, you'll have to fix the conflicts, I guess we removed some more fixed pages from setup.cfg

Another attempt to get the conflicts resolved with setup.cfg
Incorporated the requested changes.
Rollback strange changes to setup.cfg and hopefully resolve
the merge conflict.
Another attempt to fix the merge conflict with setup.cfg
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do the merge from master, and fix the conflicts please. We can't merge this PR otherwise.

@jreback
Copy link
Contributor

jreback commented Dec 18, 2018

pls merge master

Fixed merge errors with setup.cfg, reapplying changes in this version
@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #24322 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24322      +/-   ##
==========================================
- Coverage   92.28%   92.28%   -0.01%     
==========================================
  Files         162      162              
  Lines       51831    51835       +4     
==========================================
+ Hits        47833    47835       +2     
- Misses       3998     4000       +2
Flag Coverage Δ
#multiple 90.68% <ø> (-0.01%) ⬇️
#single 43% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/util/_test_decorators.py 90.54% <0%> (-2.71%) ⬇️
pandas/core/indexes/period.py 93.09% <0%> (+0.03%) ⬆️
pandas/core/reshape/tile.py 94.82% <0%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3675c29...70f5b2e. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #24322 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24322      +/-   ##
==========================================
- Coverage   92.28%   92.28%   -0.01%     
==========================================
  Files         162      162              
  Lines       51831    51835       +4     
==========================================
+ Hits        47833    47835       +2     
- Misses       3998     4000       +2
Flag Coverage Δ
#multiple 90.68% <ø> (-0.01%) ⬇️
#single 43% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/util/_test_decorators.py 90.54% <0%> (-2.71%) ⬇️
pandas/core/indexes/period.py 93.09% <0%> (+0.03%) ⬆️
pandas/core/reshape/tile.py 94.82% <0%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3675c29...1a2a225. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Dec 18, 2018
@jreback jreback merged commit a34adac into pandas-dev:master Dec 18, 2018
@jreback
Copy link
Contributor

jreback commented Dec 18, 2018

thanks @Seuss27

@Seuss27 Seuss27 deleted the v0.13 branch December 18, 2018 19:41
TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request Dec 20, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Fix flake8 issues in doc/source/whatsnew/v0.13.*.rst
4 participants