-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Fix flake8 issues in doc/source/whatsnew/v0.13.*.rst #24256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Milestone
Comments
May I work on this one? |
sure, thanks @Seuss27 |
Seuss27
added a commit
to Seuss27/pandas
that referenced
this issue
Dec 16, 2018
Seuss27
added a commit
to Seuss27/pandas
that referenced
this issue
Dec 16, 2018
Added the setup.cfg file
Seuss27
added a commit
to Seuss27/pandas
that referenced
this issue
Dec 17, 2018
Added the flake8-group: ignore to fix the intentional E999 errors and fixed the remaining flake8 issues in v0.13.0.rst
Seuss27
added a commit
to Seuss27/pandas
that referenced
this issue
Dec 17, 2018
Corrected issues in v0.13.1.rst
Seuss27
added a commit
to Seuss27/pandas
that referenced
this issue
Dec 17, 2018
Updated setup.cfg to the most recent version before PR
1 task
Seuss27
added a commit
to Seuss27/pandas
that referenced
this issue
Dec 17, 2018
Added missing space in setup.cfg exclusion section.
Seuss27
added a commit
to Seuss27/pandas
that referenced
this issue
Dec 17, 2018
One more try with setup.cfg...
Seuss27
added a commit
to Seuss27/pandas
that referenced
this issue
Dec 18, 2018
One more try with setup.cfg...
Seuss27
added a commit
to Seuss27/pandas
that referenced
this issue
Dec 18, 2018
Another attempt to get the conflicts resolved with setup.cfg Incorporated the requested changes.
Seuss27
added a commit
to Seuss27/pandas
that referenced
this issue
Dec 18, 2018
Rollback strange changes to setup.cfg and hopefully resolve the merge conflict.
Seuss27
added a commit
to Seuss27/pandas
that referenced
this issue
Dec 18, 2018
….13*" This reverts commit bb06bdb.
Seuss27
added a commit
to Seuss27/pandas
that referenced
this issue
Dec 18, 2018
Another attempt to fix the merge conflict with setup.cfg
Seuss27
added a commit
to Seuss27/pandas
that referenced
this issue
Dec 18, 2018
Fixed merge errors with setup.cfg, reapplying changes in this version
Seuss27
added a commit
to Seuss27/pandas
that referenced
this issue
Dec 18, 2018
Implemented remaining requested changes...
jreback
pushed a commit
that referenced
this issue
Dec 18, 2018
TomAugspurger
pushed a commit
to TomAugspurger/pandas
that referenced
this issue
Dec 20, 2018
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this issue
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this issue
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
xref: #24177
We didn't start validating the format of PEP8 and other code standards in the documentation examples until recently. We still have some files with errors, that we need to skip, and that we should fix, so we can start validating them.
Two steps are required to replicate the issue
Edit
setup.cfg
in the pandas home, and in the flake8-rst section, remove from theexclude
list the filedoc/source/whatsnew/v0.13.0.rst
&doc/source/whatsnew/v0.13.1.rst
Remove the import block (
from pandas import *
) from the lines (8-11) of the filev0.13.*.rst
.After that, running the next command will report the errors in the file (note that syntax error usually prevent to validate other errors, and the list of errors to fix can become much longer when the syntax error is fixed (please make sure that you are using
flake8-rst
version 0.7.0 or higher):Once all the errors are addressed, please open a pull request with the fixes in the file, and removing the file from setup.cfg. If you need to do something that feels wrong to fix an error, please ask in a comment to this issue. Please avoid other unrelated changes, which can be addressed in a separate pull request.
cc: @datapythonista
The text was updated successfully, but these errors were encountered: