Skip to content

CLN: Add issue number #24313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2018
Merged

CLN: Add issue number #24313

merged 1 commit into from
Dec 17, 2018

Conversation

alimcmaster1
Copy link
Member

Minor follow up on #24307. Based on @h-vetinari 's comment

@pep8speaks
Copy link

Hello @alimcmaster1! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Dec 16, 2018

Codecov Report

Merging #24313 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24313   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         162      162           
  Lines       51831    51831           
=======================================
  Hits        47831    47831           
  Misses       4000     4000
Flag Coverage Δ
#multiple 90.68% <ø> (ø) ⬆️
#single 43.01% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41780e5...83ce946. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 16, 2018

Codecov Report

Merging #24313 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24313   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         162      162           
  Lines       51831    51831           
=======================================
  Hits        47831    47831           
  Misses       4000     4000
Flag Coverage Δ
#multiple 90.68% <ø> (ø) ⬆️
#single 43.01% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41780e5...83ce946. Read the comment docs.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@datapythonista datapythonista added the Testing pandas testing functions or related to the test suite label Dec 17, 2018
@WillAyd WillAyd merged commit 122edfc into pandas-dev:master Dec 17, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@alimcmaster1 alimcmaster1 deleted the add-issue branch December 25, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants