Skip to content

TST: Fix flakey hypothesis apply test #24307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 16, 2018
Merged

TST: Fix flakey hypothesis apply test #24307

merged 2 commits into from
Dec 16, 2018

Conversation

alimcmaster1
Copy link
Member

Follow up based on comments in #23849

@mroeschke mind reviewing?

@pep8speaks
Copy link

Hello @alimcmaster1! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Dec 16, 2018

Codecov Report

Merging #24307 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24307   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         162      162           
  Lines       51827    51827           
=======================================
  Hits        47827    47827           
  Misses       4000     4000
Flag Coverage Δ
#multiple 90.68% <ø> (ø) ⬆️
#single 43.01% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41681c8...aa2a618. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 16, 2018 •
edited
Loading

Codecov Report

Merging #24307 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24307      +/-   ##
==========================================
+ Coverage   92.28%   92.28%   +<.01%     
==========================================
  Files         162      162              
  Lines       51827    51831       +4     
==========================================
+ Hits        47827    47831       +4     
  Misses       4000     4000
Flag Coverage Δ
#multiple 90.68% <ø> (ø) ⬆️
#single 43.01% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/period.py 93.06% <0%> (ø) ⬆️
pandas/core/arrays/datetimelike.py 96.44% <0%> (ø) ⬆️
pandas/core/arrays/period.py 98.5% <0%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41681c8...70bab10. Read the comment docs.

TomAugspurger
TomAugspurger approved these changes Dec 16, 2018
View reviewed changes
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few lint failures from unused imports.

@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Dec 16, 2018
@TomAugspurger TomAugspurger added the Testing pandas testing functions or related to the test suite label Dec 16, 2018
@jreback jreback merged commit 6643a97 into pandas-dev:master Dec 16, 2018
@jreback
Copy link
Contributor

jreback commented Dec 16, 2018

thanks @alimcmaster1

h-vetinari
h-vetinari reviewed Dec 16, 2018
View reviewed changes
pandas/tests/frame/test_apply.py
@given(index=indices(max_length=5), num_columns=integers(0, 5))
@settings(deadline=1000)
def test_frequency_is_original(self, index, num_columns):
# GH 22150
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the issue number got removed inadvertently.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake - added back here: #24313

@alimcmaster1 alimcmaster1 mentioned this pull request Dec 16, 2018
Merged
@mroeschke
Copy link
Member

Thanks @alimcmaster1!

@mroeschke mroeschke mentioned this pull request Feb 3, 2019
Closed
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@alimcmaster1 @Pingviinituutti
TST: Fix flakey hypothesis apply test (pandas-dev#24307)
69185a5
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@alimcmaster1 @Pingviinituutti
TST: Fix flakey hypothesis apply test (pandas-dev#24307)
8d4f4c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-vetinari h-vetinari h-vetinari left review comments

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

TST: Hypothesis may draw a date outside of date_range's range
6 participants
@alimcmaster1 @pep8speaks @jreback @mroeschke @TomAugspurger @h-vetinari