Skip to content

DOC: FIx flake8 errors for whatsnew v0.7.* -v0.9.* rst #24273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 14, 2018
Merged

DOC: FIx flake8 errors for whatsnew v0.7.* -v0.9.* rst #24273

merged 8 commits into from
Dec 14, 2018

Conversation

saurav2608
Copy link

@saurav2608 saurav2608 changed the title Whatsnew 7-9 DOC: FIx flake8 errors for whatsnew v0.7.* -v0.9.* rst Dec 13, 2018
@saurav2608 saurav2608 mentioned this pull request Dec 13, 2018
Closed
jorisvandenbossche
jorisvandenbossche reviewed Dec 13, 2018
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some minor comments

@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #24273 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24273   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         162      162           
  Lines       51785    51785           
=======================================
  Hits        47758    47758           
  Misses       4027     4027
Flag Coverage Δ
#multiple 90.62% <ø> (ø) ⬆️
#single 43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c037128...874280c. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 13, 2018 •
edited
Loading

Codecov Report

Merging #24273 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24273   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         162      162           
  Lines       51828    51828           
=======================================
  Hits        47799    47799           
  Misses       4029     4029
Flag Coverage Δ
#multiple 90.62% <ø> (ø) ⬆️
#single 43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4974758...b015b1e. Read the comment docs.

datapythonista
datapythonista approved these changes Dec 14, 2018
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @saurav2608

I'd leave the check in ci/code_checks.py for when we remove all the imports from compat (or may be it's not even worth it)

jreback
jreback requested changes Dec 14, 2018
View reviewed changes
datapythonista
datapythonista reviewed Dec 14, 2018
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, same things as the other PR

@jreback
Copy link
Contributor

jreback commented Dec 14, 2018

can you merge master

@jreback jreback added this to the 0.24.0 milestone Dec 14, 2018
@jreback jreback merged commit 4efc819 into pandas-dev:master Dec 14, 2018
@jreback
Copy link
Contributor

jreback commented Dec 14, 2018

thanks!

@saurav2608 saurav2608 deleted the whatsnew-7-9 branch December 16, 2018 07:11
JimJeon added a commit to JimJeon/pandas that referenced this pull request Dec 16, 2018
@JimJeon
DOC: Fixes import of StringIO
7e4bc37 
From conversations in pandas-dev#24273, I found that everywhere in pandas
documentation should use `io` and not `compat`.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@saurav-chakravorty @Pingviinituutti
DOC: FIx flake8 errors for whatsnew v0.7.* -v0.9.* rst (pandas-dev#24273
7074eb8 
)
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@saurav-chakravorty @Pingviinituutti
DOC: FIx flake8 errors for whatsnew v0.7.* -v0.9.* rst (pandas-dev#24273
6fe28fb 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

@datapythonista datapythonista datapythonista approved these changes

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Clean Docs
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

DOC: Fix flake8 issues in doc/source/whatsnew/v0.9.*.rst, v0.8.*.rst & v0.7.*.rst,
5 participants
@saurav2608 @jreback @jorisvandenbossche @datapythonista @saurav-chakravorty