-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Flake8 rst v0.14.x.rst #24253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flake8 rst v0.14.x.rst #24253
Conversation
Seuss27
commented
Dec 12, 2018
•
edited
Loading
edited
- closes DOC: Fix flake8 issues in doc/source/whatsnew/v0.14.*.rst #24240
Codecov Report
@@ Coverage Diff @@
## master #24253 +/- ##
=======================================
Coverage 92.21% 92.21%
=======================================
Files 162 162
Lines 51768 51768
=======================================
Hits 47739 47739
Misses 4029 4029
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24253 +/- ##
==========================================
+ Coverage 92.21% 92.22% +<.01%
==========================================
Files 162 162
Lines 51768 51789 +21
==========================================
+ Hits 47739 47763 +24
+ Misses 4029 4026 -3
Continue to review full report at Codecov.
|
Thank you very much for the feedback guys. I appreciate it. This is my first getting involved with something like this. I am a little confused because the instructions provided indicated to remove the lines 8-10: I have now revised that to read
Did I miss a directive somewhere (and is this the desirable change?) Fianlly, I believe the suggested changes to setup.cfg have already been made and commited. Thanks again for the support, sorry for being such a pain. |
@Seuss27 at the beginning of each file, we've got a Some time ago it was decided that to avoid repetition, we won't be shoring the So, if you can simply remove the imports from the edited files in this PR, that would be great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments. Please render the pages ./doc/make.py html --no-api
and visualize them, there are few things that are broken and you can detect them yourself
…snew/v0.14.* Implemented changes based on feedback.
Thank you so much for taking the time to provide the feedback. I really appreciate the help. I have implemented the requested changes... |
…snew/v0.14.* Update the error text in the documentation as directed and fixed formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @Seuss27
thanks @Seuss27 |