Skip to content

Flake8 rst v0.14.x.rst #24253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 14, 2018
Merged

Conversation

Seuss27
Copy link
Contributor

@Seuss27 Seuss27 commented Dec 12, 2018

@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #24253 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24253   +/-   ##
=======================================
  Coverage   92.21%   92.21%           
=======================================
  Files         162      162           
  Lines       51768    51768           
=======================================
  Hits        47739    47739           
  Misses       4029     4029
Flag Coverage Δ
#multiple 90.61% <ø> (ø) ⬆️
#single 43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bc42f9...2374c53. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #24253 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24253      +/-   ##
==========================================
+ Coverage   92.21%   92.22%   +<.01%     
==========================================
  Files         162      162              
  Lines       51768    51789      +21     
==========================================
+ Hits        47739    47763      +24     
+ Misses       4029     4026       -3
Flag Coverage Δ
#multiple 90.62% <ø> (ø) ⬆️
#single 43.01% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/resample.py 96.81% <0%> (-0.18%) ⬇️
pandas/util/testing.py 87.41% <0%> (-0.1%) ⬇️
pandas/core/frame.py 96.91% <0%> (ø) ⬆️
pandas/core/series.py 93.7% <0%> (ø) ⬆️
pandas/core/indexes/base.py 96.27% <0%> (ø) ⬆️
pandas/core/base.py 97.64% <0%> (ø) ⬆️
pandas/core/arrays/categorical.py 95.31% <0%> (ø) ⬆️
pandas/io/formats/format.py 97.98% <0%> (+0.01%) ⬆️
pandas/io/formats/html.py 98.64% <0%> (+0.03%) ⬆️
pandas/io/json/normalize.py 96.93% <0%> (+0.06%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bc42f9...a3c1059. Read the comment docs.

@jreback jreback added the Docs label Dec 13, 2018
@Seuss27
Copy link
Contributor Author

Seuss27 commented Dec 13, 2018

Thank you very much for the feedback guys. I appreciate it. This is my first getting involved with something like this. I am a little confused because the instructions provided indicated to remove the

lines 8-10:
from pandas import *

I have now revised that to read

import pandas as pd

Did I miss a directive somewhere (and is this the desirable change?)

Fianlly, I believe the suggested changes to setup.cfg have already been made and commited.

Thanks again for the support, sorry for being such a pain.

@datapythonista
Copy link
Member

@Seuss27 at the beginning of each file, we've got a {{ header }} that when the documentation is build, is replaced by some instructions (you can see which in doc/source/conf.py).

Some time ago it was decided that to avoid repetition, we won't be shoring the import pandas as pd to the users, and we assume they know about it. But it is still needed the make the code run, that's why we have in the header content in a block that is not visible.

So, if you can simply remove the imports from the edited files in this PR, that would be great.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments. Please render the pages ./doc/make.py html --no-api and visualize them, there are few things that are broken and you can detect them yourself

…snew/v0.14.*

Implemented changes based on feedback.
@Seuss27
Copy link
Contributor Author

Seuss27 commented Dec 13, 2018

Thank you so much for taking the time to provide the feedback. I really appreciate the help. I have implemented the requested changes...

…snew/v0.14.*

Update the error text in the documentation as directed and fixed
formatting.
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @Seuss27

@jreback jreback added this to the 0.24.0 milestone Dec 14, 2018
@jreback jreback merged commit 5cedb39 into pandas-dev:master Dec 14, 2018
@jreback
Copy link
Contributor

jreback commented Dec 14, 2018

thanks @Seuss27

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Fix flake8 issues in doc/source/whatsnew/v0.14.*.rst
3 participants