Fix flake8 issues on v19, v20 and v21.0.rst #24236

thoo · 2018-12-11T17:47:16Z

closes #24219
closes #24220
closes #24222

run python make.py --single whatsnew/v0.19.0, python make.py --single whatsnew/v0.20.0 etc.
Related to: DOC: Fix flake8 issue in whatsnew files #24177

FHaase · 2018-12-11T18:12:40Z

doc/source/whatsnew/v0.19.0.rst

@@ -319,15 +313,15 @@ These provide date offsets anchored (by default) to the 15th and end of month, a

 .. ipython:: python

-    Timestamp('2016-01-01') + SemiMonthEnd()
+    pd.Timestamp('2016-01-01') + SemiMonthEnd()


Is it possible to use pd.offsets.SemiMonthEnd()?
I find it more descriptive as the reader doesn't have to scroll around to find where SemiMonthEnd() came from.

Do you mean pd.tseries.offsets.SemiMonthEnd()? I think SemiMonthEnd() and SemiMonthBegin() are used right after importing from pandas.tseries.offsets and that was the only time they were used. I could be wrong. Let me know if it is the case.

pd.tseries.offsets is imported as pd.offsets. They are basically the same. But maybe it's better to leave it like pd.tseries.offsets.SemiMonthEnd() as I don't know whether it's been the case in v0.19.0

The document for v0.19 also uses a single class name like BDay or DataOffset. So I will keep it as it is now for consistency.

doc/source/whatsnew/v0.20.0.rst

doc/source/whatsnew/v0.21.0.rst

doc/source/whatsnew/v0.20.0.rst

codecov · 2018-12-11T19:15:18Z

Codecov Report

Merging #24236 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #24236   +/-   ##
=======================================
  Coverage   92.21%   92.21%           
=======================================
  Files         162      162           
  Lines       51763    51763           
=======================================
  Hits        47733    47733           
  Misses       4030     4030

Flag	Coverage Δ
#multiple	`90.61% <ø> (ø)`	⬆️
#single	`43% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6c7f6b...78372e4. Read the comment docs.

codecov · 2018-12-11T19:15:22Z

Codecov Report

Merging #24236 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #24236      +/-   ##
==========================================
+ Coverage   92.21%   92.21%   +<.01%     
==========================================
  Files         162      162              
  Lines       51768    51768              
==========================================
+ Hits        47739    47740       +1     
+ Misses       4029     4028       -1

Flag	Coverage Δ
#multiple	`90.61% <ø> (ø)`	⬆️
#single	`43% <ø> (ø)`	⬆️

Impacted Files	Coverage Δ
pandas/util/testing.py	`87.41% <0%> (-0.1%)`	⬇️
pandas/io/json/json.py	`93.09% <0%> (+0.47%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bc42f9...aa8f5b4. Read the comment docs.

WillAyd · 2018-12-12T06:32:48Z

doc/source/whatsnew/v0.20.0.rst

-       branch = 'master',
-       path = 'pandas/tests/io/parser/data/salaries.csv.bz2',
-   )
+   url = (r'https://github.com/{repo}/raw/{branch}/{path}'


Why a raw string here?

* upstream/master: pct change bug issue 21200 (pandas-dev#21235) DOC: Fix summaries not ending with a period (pandas-dev#24190) DOC: Add back currentmodule to api.rst (pandas-dev#24232) DOC: Fixed implicit imports for whatsnew (v >= version 20.0) (pandas-dev#24199) remove enum import for PY2 compat, xref pandas-dev#22802 (pandas-dev#24170) CI: Simplify Azure Pipelines configuration files (pandas-dev#23111) REF/TST: Add more pytest idiom to indexing/multiindex/test_getitem.py (pandas-dev#24053)

jreback · 2018-12-12T13:21:59Z

doc/source/whatsnew/v0.19.0.rst

-       'ask': [720.93, 51.96, 51.98, 52.00,
-               720.93, 98.01, 720.88, 52.03]},
-       columns=['time', 'ticker', 'bid', 'ask'])
+    trades = pd.DataFrame({


is this the new standard to align not on the ipython (the i), but 1 space in? this seems odd

@datapythonista

this seems inconsistent even in this file

jreback · 2018-12-12T13:22:44Z

doc/source/whatsnew/v0.19.0.rst

-     df
-     df.resample('M', on='date').sum()
-     df.resample('M', level='d').sum()
+    df = pd.DataFrame({'date': pd.date_range('2015-01-01', freq='W', periods=5),


here its different

jreback · 2018-12-12T13:22:57Z

doc/source/whatsnew/v0.19.0.rst

-                                     pd.Timestamp('20130101 09:00:05'),
-                                     pd.Timestamp('20130101 09:00:06')],
-                                    name='foo'))
+   dft = pd.DataFrame({'B': [0, 1, 2, np.nan, 4]},


I think I realigned all to overlap with the first letter "i" or "c". Let me know if I miss any block.

* upstream/master: DOC: Fix PEP-8 issues in indexing-, missing_data-, options- and release.rst (pandas-dev#24089)

jreback · 2018-12-13T02:00:05Z

thanks @thoo

Fix flake8 issues on v19, v20 and v21.0.rst

6f4a546

FHaase suggested changes Dec 11, 2018

View reviewed changes

Fix at L293

78372e4

thoo added 2 commits December 11, 2018 14:20

Fix code-block

1131f71

Fix code-block indent

c529863

jreback added the Docs label Dec 11, 2018

thoo added 2 commits December 11, 2018 15:33

Fix code-block

b67a4b5

Add spaces to align code-lines

221d35f

WillAyd reviewed Dec 12, 2018

View reviewed changes

thoo added 2 commits December 12, 2018 07:54

fix raw string

02f5844

jreback requested changes Dec 12, 2018

View reviewed changes

thoo added 2 commits December 12, 2018 10:20

code block alignments

fc214e3

Merge remote-tracking branch 'upstream/master' into flake8_whatsnew21

aa8f5b4

* upstream/master: DOC: Fix PEP-8 issues in indexing-, missing_data-, options- and release.rst (pandas-dev#24089)

jreback added this to the 0.24.0 milestone Dec 13, 2018

jreback approved these changes Dec 13, 2018

View reviewed changes

jreback merged commit 1d18430 into pandas-dev:master Dec 13, 2018

saurav2608 mentioned this pull request Dec 13, 2018

DOC: Fix flake8 issue in whatsnew files #24177

Closed

thoo deleted the flake8_whatsnew21 branch January 2, 2019 20:26

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

Fix flake8 issues on v19, v20 and v21.0.rst (pandas-dev#24236)

687a785

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

Fix flake8 issues on v19, v20 and v21.0.rst (pandas-dev#24236)

8f0b6bc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix flake8 issues on v19, v20 and v21.0.rst #24236

Fix flake8 issues on v19, v20 and v21.0.rst #24236

thoo commented Dec 11, 2018 •

edited by jreback

Loading

FHaase Dec 11, 2018

thoo Dec 11, 2018

FHaase Dec 11, 2018

thoo Dec 12, 2018

codecov bot commented Dec 11, 2018

codecov bot commented Dec 11, 2018 •

edited

Loading

WillAyd Dec 12, 2018

thoo Dec 12, 2018

jreback Dec 12, 2018

jreback Dec 12, 2018

jreback Dec 12, 2018

jreback Dec 12, 2018

jreback Dec 12, 2018

thoo Dec 12, 2018

jreback commented Dec 13, 2018

Fix flake8 issues on v19, v20 and v21.0.rst #24236

Fix flake8 issues on v19, v20 and v21.0.rst #24236

Conversation

thoo commented Dec 11, 2018 • edited by jreback Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Dec 11, 2018

Codecov Report

codecov bot commented Dec 11, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback commented Dec 13, 2018

thoo commented Dec 11, 2018 •

edited by jreback

Loading

codecov bot commented Dec 11, 2018 •

edited

Loading