DOC: Fix summaries not ending with a period #24190

YuechengWu · 2018-12-10T00:54:12Z

I have fixed all 'Summary does not end with a period' issue except these two:

I couldn't find the linenumbers in the corresponding file, and also couldn't fix it by looking for 'argmin' or 'argmax' in Panda directory. Please advise if there is anything else I could try.

closes DOC: Fix docstrings error SS03 - Summary does not end with a period #24164
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

pep8speaks · 2018-12-10T00:54:22Z

Hello @YuechengWu! Thanks for updating the PR.

There are no PEP8 issues in the file pandas/core/accessor.py !
There are no PEP8 issues in the file pandas/core/arrays/categorical.py !
There are no PEP8 issues in the file pandas/core/arrays/datetimes.py !
There are no PEP8 issues in the file pandas/core/base.py !
There are no PEP8 issues in the file pandas/core/dtypes/dtypes.py !
There are no PEP8 issues in the file pandas/core/generic.py !
There are no PEP8 issues in the file pandas/core/indexes/accessors.py !
There are no PEP8 issues in the file pandas/plotting/_core.py !

Comment last updated on December 10, 2018 at 00:59 Hours UTC

codecov · 2018-12-10T01:54:12Z

Codecov Report

Merging #24190 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #24190      +/-   ##
==========================================
- Coverage   92.21%   92.21%   -0.01%     
==========================================
  Files         162      162              
  Lines       51723    51723              
==========================================
- Hits        47695    47694       -1     
- Misses       4028     4029       +1

Flag	Coverage Δ
#multiple	`90.61% <100%> (ø)`	⬆️
#single	`43.03% <83.33%> (-0.01%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/indexes/accessors.py	`91.08% <ø> (ø)`	⬆️
pandas/core/accessor.py	`98.79% <ø> (ø)`	⬆️
pandas/core/dtypes/dtypes.py	`95.33% <ø> (ø)`	⬆️
pandas/core/base.py	`97.64% <ø> (ø)`	⬆️
pandas/core/arrays/categorical.py	`95.4% <ø> (ø)`	⬆️
pandas/core/generic.py	`96.65% <ø> (ø)`	⬆️
pandas/plotting/_core.py	`83.58% <ø> (ø)`	⬆️
pandas/core/arrays/datetimes.py	`98.56% <100%> (ø)`	⬆️
pandas/io/json/json.py	`92.61% <0%> (-0.48%)`	⬇️
pandas/util/testing.py	`87.51% <0%> (+0.09%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77278ba...88d6664. Read the comment docs.

codecov · 2018-12-10T01:54:14Z

Codecov Report

Merging #24190 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #24190   +/-   ##
=======================================
  Coverage   92.21%   92.21%           
=======================================
  Files         162      162           
  Lines       51763    51763           
=======================================
  Hits        47733    47733           
  Misses       4030     4030

Flag	Coverage Δ
#multiple	`90.61% <100%> (ø)`	⬆️
#single	`43% <100%> (ø)`	⬆️

Impacted Files	Coverage Δ
pandas/core/indexes/accessors.py	`91.08% <ø> (ø)`	⬆️
pandas/core/accessor.py	`98.79% <ø> (ø)`	⬆️
pandas/core/dtypes/dtypes.py	`95.33% <ø> (ø)`	⬆️
pandas/core/base.py	`97.64% <ø> (ø)`	⬆️
pandas/core/arrays/categorical.py	`95.3% <ø> (ø)`	⬆️
pandas/core/generic.py	`96.65% <ø> (ø)`	⬆️
pandas/plotting/_core.py	`83.58% <ø> (ø)`	⬆️
pandas/core/arrays/datetimes.py	`98.56% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6c7f6b...dad7f70. Read the comment docs.

datapythonista

Looks good, if you don't mind, there are few things we can also fix here.

And you added and committed a scripts/tmp.xlsx file that shouldn't be in the PR.

pandas/core/accessor.py

pandas/core/arrays/categorical.py

pandas/core/arrays/datetimes.py

datapythonista

The argmin / argmax are deprecated with a function, and is not trivial to change their docstrings. I think we should be able to remove them soon, so don't worry about them.

pandas/core/arrays/datetimes.py

datapythonista

Sorry, didn't see couple of spaces that shouldn't be there. If you can approve my suggested changes, we're ready to merge.

pandas/core/arrays/datetimes.py

Co-Authored-By: YuechengWu <[email protected]>

YuechengWu · 2018-12-10T02:55:43Z

@datapythonista I committed those two changes. I think we are ready to go. 👍

datapythonista

lgtm, thanks @YuechengWu

YuechengWu · 2018-12-10T03:08:35Z

@datapythonista my pleasure as always

pandas/core/arrays/datetimes.py

datapythonista · 2018-12-11T12:07:31Z

@YuechengWu, when you accept changes in the github interface, github creates commits for them. So, now, the history in your local copy and the history in the remote branch diverged (both have a common ancestor, but splitted and they are different now). When you push, git can't simply add your latest commits to the history on the repo.

To fix it, is as simple as git pull from your branch. This will fetch the commits that github added locally, and merge them to your history. Then a push will work.

YuechengWu · 2018-12-11T13:44:49Z

@datapythonista yest, it's working now. Thank you so much. I also reverted "{}" to be "\n{}\n". Let me know if any further changes are required.

datapythonista · 2018-12-11T14:21:16Z

Not sure what you did, but you've got many unrelated changes in this PR. Take a look at the first section here, that should help fix it: https://datapythonista.github.io/blog/useful-git-commands.html

…to issue-24164

YuechengWu · 2018-12-11T14:36:47Z

@datapythonista I tried to clean up the history, it's now in the commit "all my changes in a single commit", let me know if there is anything else. Thanks.

datapythonista · 2018-12-11T14:38:41Z

Check this and the list of commits in the PR: https://github.com/pandas-dev/pandas/pull/24190/files

YuechengWu · 2018-12-11T14:47:45Z

@datapythonista I am not sure how those changes regarding #24053 got into my PR.

datapythonista · 2018-12-11T14:49:33Z

I have no idea either, but happens often to many people. If you follow the instructions in the post I sent you, you should be able to fix the PR

…to issue-24164

…sue-24164

…to issue-24164

YuechengWu · 2018-12-11T19:57:31Z

@datapythonista yes, I think I have fixed it now, phew! Thanks for your help, let me know if there is anything else please.

datapythonista

lgtm, thanks @YuechengWu

@WillAyd merge when you're happy

WillAyd · 2018-12-11T23:15:50Z

Thanks @YuechengWu !

YuechengWu · 2018-12-12T01:04:55Z

@datapythonista @WillAyd My pleasure, glad I could help!

* upstream/master: pct change bug issue 21200 (pandas-dev#21235) DOC: Fix summaries not ending with a period (pandas-dev#24190) DOC: Add back currentmodule to api.rst (pandas-dev#24232) DOC: Fixed implicit imports for whatsnew (v >= version 20.0) (pandas-dev#24199) remove enum import for PY2 compat, xref pandas-dev#22802 (pandas-dev#24170) CI: Simplify Azure Pipelines configuration files (pandas-dev#23111) REF/TST: Add more pytest idiom to indexing/multiindex/test_getitem.py (pandas-dev#24053)

fix Summary does not end with a period error

91ab671

YuechengWu added 2 commits December 9, 2018 19:57

fixed generic.py PEP8 - line too long issues

b366819

fixed generic.py PEP8 - trailing whitespace issues

88d6664

datapythonista requested changes Dec 10, 2018

View reviewed changes

pandas/core/accessor.py Outdated Show resolved Hide resolved

pandas/core/arrays/categorical.py Outdated Show resolved Hide resolved

pandas/core/arrays/categorical.py Outdated Show resolved Hide resolved

pandas/core/arrays/datetimes.py Outdated Show resolved Hide resolved

datapythonista changed the title ~~fix Summary does not end with a period error~~ DOC: Fix summaries not ending with a period Dec 10, 2018

datapythonista added Docs Clean labels Dec 10, 2018

YuechengWu added 2 commits December 9, 2018 21:35

fixed minor errors

ad50026

removed a few more \n

d3d0bd0

datapythonista reviewed Dec 10, 2018

View reviewed changes

pandas/core/arrays/datetimes.py Outdated Show resolved Hide resolved

added back required \n

97444fb

datapythonista reviewed Dec 10, 2018

View reviewed changes

pandas/core/arrays/datetimes.py Outdated Show resolved Hide resolved

pandas/core/arrays/datetimes.py Outdated Show resolved Hide resolved

datapythonista and others added 2 commits December 9, 2018 21:53

Update pandas/core/arrays/datetimes.py

dc0a303

Co-Authored-By: YuechengWu <[email protected]>

Update pandas/core/arrays/datetimes.py

8639841

Co-Authored-By: YuechengWu <[email protected]>

datapythonista approved these changes Dec 10, 2018

View reviewed changes

datapythonista self-assigned this Dec 11, 2018

WillAyd requested changes Dec 11, 2018

View reviewed changes

pandas/core/arrays/datetimes.py Outdated Show resolved Hide resolved

pandas/core/arrays/datetimes.py Show resolved Hide resolved

YuechengWu added 6 commits December 11, 2018 02:13

fix Summary does not end with a period error

b052287

fixed generic.py PEP8 - line too long issues

41e4757

fixed generic.py PEP8 - trailing whitespace issues

074b925

fixed minor errors

a1e0df2

removed a few more \n

860bb8d

revert back \n

ce03033

fixing conflicts

b41fed4

revert \n

c10e7c5

YuechengWu added 2 commits December 11, 2018 09:32

all my changes in a single commit

5f67556

Merge branch 'issue-24164' of https://github.com/YuechengWu/pandas in…

7b8d1e8

…to issue-24164

YuechengWu added 5 commits December 11, 2018 14:44

All my changes in a single commit

1950b08

Merge branch 'issue-24164' of https://github.com/YuechengWu/pandas in…

671b5bd

…to issue-24164

clean up branch history

18350bf

Merge branch 'master' of https://github.com/YuechengWu/pandas into is…

aecb483

…sue-24164

Merge branch 'issue-24164' of https://github.com/YuechengWu/pandas in…

dad7f70

…to issue-24164

datapythonista approved these changes Dec 11, 2018

View reviewed changes

WillAyd approved these changes Dec 11, 2018

View reviewed changes

WillAyd merged commit 89f0441 into pandas-dev:master Dec 11, 2018

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

DOC: Fix summaries not ending with a period (pandas-dev#24190)

3793b61

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

DOC: Fix summaries not ending with a period (pandas-dev#24190)

60d5f59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DOC: Fix summaries not ending with a period #24190

DOC: Fix summaries not ending with a period #24190

YuechengWu commented Dec 10, 2018 •

edited

Loading

pep8speaks commented Dec 10, 2018 •

edited

Loading

codecov bot commented Dec 10, 2018

codecov bot commented Dec 10, 2018 •

edited

Loading

datapythonista left a comment

datapythonista left a comment

datapythonista left a comment

YuechengWu commented Dec 10, 2018

datapythonista left a comment

YuechengWu commented Dec 10, 2018

datapythonista commented Dec 11, 2018

YuechengWu commented Dec 11, 2018

datapythonista commented Dec 11, 2018

YuechengWu commented Dec 11, 2018 •

edited

Loading

datapythonista commented Dec 11, 2018

YuechengWu commented Dec 11, 2018

datapythonista commented Dec 11, 2018

YuechengWu commented Dec 11, 2018

datapythonista left a comment

WillAyd commented Dec 11, 2018

YuechengWu commented Dec 12, 2018

DOC: Fix summaries not ending with a period #24190

DOC: Fix summaries not ending with a period #24190

Conversation

YuechengWu commented Dec 10, 2018 • edited Loading

pep8speaks commented Dec 10, 2018 • edited Loading

Comment last updated on December 10, 2018 at 00:59 Hours UTC

codecov bot commented Dec 10, 2018

Codecov Report

codecov bot commented Dec 10, 2018 • edited Loading

Codecov Report

datapythonista left a comment

Choose a reason for hiding this comment

datapythonista left a comment

Choose a reason for hiding this comment

datapythonista left a comment

Choose a reason for hiding this comment

YuechengWu commented Dec 10, 2018

datapythonista left a comment

Choose a reason for hiding this comment

YuechengWu commented Dec 10, 2018

datapythonista commented Dec 11, 2018

YuechengWu commented Dec 11, 2018

datapythonista commented Dec 11, 2018

YuechengWu commented Dec 11, 2018 • edited Loading

datapythonista commented Dec 11, 2018

YuechengWu commented Dec 11, 2018

datapythonista commented Dec 11, 2018

YuechengWu commented Dec 11, 2018

datapythonista left a comment

Choose a reason for hiding this comment

WillAyd commented Dec 11, 2018

YuechengWu commented Dec 12, 2018

YuechengWu commented Dec 10, 2018 •

edited

Loading

pep8speaks commented Dec 10, 2018 •

edited

Loading

codecov bot commented Dec 10, 2018 •

edited

Loading

YuechengWu commented Dec 11, 2018 •

edited

Loading