Fix error GL07 #24126
Merged
Fix error GL07 #24126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ORIGINAL LIST OF ERRORS - 286 in total |
|
REMAINING ERRORS - 24 in total |
Cannot be easily fixed - because it appends two different docs Some of the remaining 24 errors can still be fixed, I just spent a lot of time on this and need a break. But some of them like I stated above cannot be resolved because they append two different docs from different files and that affects the order. I also figured out how to find the docs that are a little more difficult, so I will be coming back to the unsolved errors of #23870 . When I was fixing these, I also found some extra spaces and fixed those also, so there should be even less GL03 errors now. |
datapythonista
approved these changes
Dec 6, 2018
There was a problem hiding this comment.
lgtm, thanks a lot for taking care of all those @alexander-ponomaroff
|
@alexander-ponomaroff can you take a look at the linting errors in azure? seems like there are whitespaces in some lines you edited: https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=4807 Running locally |
Codecov Report
@@ Coverage Diff @@
## master #24126 +/- ##
==========================================
+ Coverage 92.2% 92.2% +<.01%
==========================================
Files 162 162
Lines 51701 51701
==========================================
+ Hits 47672 47673 +1
+ Misses 4029 4028 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24126 +/- ##
==========================================
- Coverage 92.2% 92.2% -0.01%
==========================================
Files 162 162
Lines 51701 51701
==========================================
- Hits 47672 47671 -1
- Misses 4029 4030 +1
Continue to review full report at Codecov.
|
|
@datapythonista it seems azure doesn't fail the build (the check here) when the linting job fails. can you fix this ASAP. IOW this PR should be an X, not in progress. |
|
@jreback, it's a bug in azure side not ours, they were expected to hotfix it yesterday, so I guess it should be fixed soon. |
|
@datapythonista on #24126 (comment) thanks. pls keep us posted. |
|
Does this PR add linting so we don't regress these changes? |
|
We can't, as there are some tricky cases that will be addressed in a follow up. But I'll be adding to the validation all the errors that we fully fix, I'm on it. |
|
Can we at least do a whitelist, to ensure that the correct ones aren't
re-broken?
Some context: these types of changes are hard to keep around when working
on large changes that may involve moving
methods between files (like the DatetimeArray PR). I'd like to not lose all
this work.
…On Thu, Dec 6, 2018 at 8:40 AM Marc Garcia ***@***.***> wrote:
We can't, as there are some tricky cases that will be addressed in a
follow up. But I'll be adding to the validation all the errors that we
fully fix, I'm on it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#24126 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIhicA2D29AIr_HHkdbQn_-2KpWamks5u2SxLgaJpZM4ZF-HU>
.
|
|
That makes sense, but we'll need to implement a For the rest (missing examples, parameters not documented...). It may make even more sense what you propose. But may be with what we have it's enough to progressively fix things and lint them (for example, focussing in |
|
@datapythonista Sorry about W293 errors. Was working on this till late and didn't check. I fixed them now. For the remaining 24 errors, I think that some of them can still be fixed, so should we keep this PR open for a little bit for me to go through them. And then leave the problematic errors that deal with appending two different docs from two different files for another PR? |
|
@alexander-ponomaroff having huge PRs is not very efficient for the reviews. Every time you make some changes and get some feedback, we need to review the whole of it again. When I create issues I divide all these fixed in chunks, among other things because of this. So, I prefer to merge this as soon as the CI is green, and address anything else in a separate PR. |
|
@datapythonista I just fixed all remaining errors, with 13 errors that combine different docs left. I already did this on this branch. Could I merge this and link the files that I changed this time? I will keep this in mind and next time divide the fixes in a few sections to make it easier to review. Sorry for the inconvenience. |
|
@datapythonista Actually nevermind, I don't want to create extra difficulties. Just merge this first and I will create a separate PR for the other ones. |
This was referenced Dec 6, 2018
|
thanks, yeah the validation / final fixes are better done in a part 2 |
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffOriginal number of errors: 286
Remaining errors: 24