-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Use only one blank line to separate sections or paragraphs #23870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Reopening. Most of the issues have been fixed, but still some left, see: #23871 (comment) |
Hey @datapythonista, I am new to open source and would like to work on this! Just curious if someone is working on it? If not I can give it a shot! Thanks! |
I think this is trickier than it looks, but surely a good first issue, and you can definitely work on it. Executing Thanks @abkosar |
Thanks! |
So started working on the issue. When I run
|
Hi @abkosar |
Hi @NatholBMX I recently started working on this again. I would still like to work on it and sorry for not updating it for a long time. |
Hi @NatholBMX When I run
I synced my fork before doing this. Is there anything that I should do differently? |
This is working for me with master. Can you make sure you run |
Hey @datapythonista, thanks for the reply. So I ran
I haven't made any changes yet so I don't think that's causing any issues. I think I'll start working on the output I got the first time I ran this but I'm just curious why it doesn't give the same output again. |
Those are warnings, they should be fixed eventually, but not relevant for what you're doing. If that's all what you get, I think there are no GL03 errors. You can also run:
If the message gets printed means that no errors are found indeed (validate_docstrings.py returns an exit code 0 if no errors are found, and the && will make the echo just be executed if that's the case) |
Yep that's exactly what happened:
|
I just saw now that this issue is for Closing this issue, but you can work on GL01 and GL02 (I'd take care of them together, since they are related). There are several errors, if you manage to fix them all (feel free to open a PR just for a subset), then please add the codes in Any question let me know. |
You can get the errors with: def foo():
"""This is incorrect.""" it should be def foo():
"""
This is correct.
""" |
Sure, I'd be happy to work on those, thanks! |
@datapythonista Sounds good to me. Should I also create seperate issues for each category like you or an issue for everything I fixed? |
Feel free to do it, but probably it's simpler that you just fix as many cases as you want not in that issue, and open a PR. The reason for creating the issue is that I think there are two many cases for a single PR (and probably a single person), so we can have someone else working on that. |
Ok sounds good, thanks! |
Hey @datapythonista -- So I want to start working on GL01 and GL02 however when I tried to do
I did the following steps before running the script:
I didn't want to create another issue just for this so wanted to ask here. Am I doing something wrong? Thanks! |
You need to rebuild the C extensions, so |
@WillAyd Thanks, it worked! |
Hey @datapythonista -- I have another question. So for example the
I thought that I'd find these methods at Am I looking at the wrong place? |
When checking for errors with
./scripts/validate_docstrings.py
, There is an error that comes up:GL03
Use only one blank line to separate sections or paragraphs
I started working on this and will create a pull request for this issue shortly to go into more detail on what I fixed.
@datapythonista
The text was updated successfully, but these errors were encountered: