Skip to content

CLN: Adjust cdef types to fix MacPython 32 bit build #24041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2018

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Dec 2, 2018

Removing the types from these array declarations because the MacPython 32 bit build was failing.

cc @jreback

@mroeschke mroeschke added the Clean label Dec 2, 2018
@codecov
Copy link

codecov bot commented Dec 2, 2018

Codecov Report

Merging #24041 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24041   +/-   ##
=======================================
  Coverage   42.46%   42.46%           
=======================================
  Files         161      161           
  Lines       51557    51557           
=======================================
  Hits        21892    21892           
  Misses      29665    29665
Flag Coverage Δ
#single 42.46% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b45eb26...1856725. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 2, 2018

Codecov Report

Merging #24041 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24041   +/-   ##
=======================================
  Coverage   42.46%   42.46%           
=======================================
  Files         161      161           
  Lines       51557    51557           
=======================================
  Hits        21892    21892           
  Misses      29665    29665
Flag Coverage Δ
#single 42.46% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b45eb26...1856725. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Dec 2, 2018
@jreback jreback merged commit 96e0bd7 into pandas-dev:master Dec 2, 2018
@jreback
Copy link
Contributor

jreback commented Dec 2, 2018

thanks @mroeschke

@mroeschke mroeschke deleted the fix_macpython_type branch December 2, 2018 17:15
@jreback
Copy link
Contributor

jreback commented Dec 2, 2018

looks like it fixed things. thanks

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants