CLN: Add missing types to tslibs/conversion.pyx #23984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #23984 +/- ##
=======================================
Coverage 92.31% 92.31%
=======================================
Files 161 161
Lines 51513 51513
=======================================
Hits 47554 47554
Misses 3959 3959
Continue to review full report at Codecov.
|
|
thanks |
|
i think this broke 32 bit https://travis-ci.org/MacPython/pandas-wheels/jobs/461611536 |
|
I am guessing it was one of these declarations, but it's not obvious to me which one it was since they are all derived from each other: |
2 tasks
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Again just variables that were not typed, and removing some unused variables.