Skip to content

BUG: Fix lxml import in show_versions #23949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 29, 2018
+1 −1
Merged

BUG: Fix lxml import in show_versions #23949

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d31f5f1
BUG: Fix lxml import in show_versions
nixphix Nov 27, 2018
83811e5
Add test case for show_version
nixphix Nov 28, 2018
0322df8
Removed test_lxml_import test case
nixphix Nov 29, 2018
0f9bae9
Update test_util.py
nixphix Nov 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pandas/tests/util/test_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from collections import OrderedDict
import locale
import os
import subprocess
import sys
from uuid import uuid4

Expand Down Expand Up @@ -530,3 +531,10 @@ def test_safe_import(monkeypatch):
monkeypatch.setitem(sys.modules, mod_name, mod)
assert not td.safe_import(mod_name, min_version="2.0")
assert td.safe_import(mod_name, min_version="1.0")


def test_lxml_import():
# See GH 23934
# lxml does not have attribute etree exception should not be thrown
subprocess.check_call([sys.executable, "-c",
"import pandas; pandas.show_versions()"])
2 changes: 1 addition & 1 deletion pandas/util/_print_versions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def show_versions(as_json=False):
("xlrd", lambda mod: mod.__VERSION__),
("xlwt", lambda mod: mod.__VERSION__),
("xlsxwriter", lambda mod: mod.__version__),
("lxml", lambda mod: mod.etree.__version__),
("lxml.etree", lambda mod: mod.__version__),
("bs4", lambda mod: mod.__version__),
("html5lib", lambda mod: mod.__version__),
("sqlalchemy", lambda mod: mod.__version__),
Expand Down